Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix HttpResultWriter ill-formatted json string #54590

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[BugFix] fix HttpResultWriter ill-formatted json string #54590

merged 1 commit into from
Jan 3, 2025
+113 −4

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Jan 2, 2025

Why I'm doing:

What I'm doing:

Fixes #54557

Introduced in #25760

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@kevincai kevincai requested a review from a team as a code owner January 2, 2025 09:06
luohaha
luohaha previously approved these changes Jan 3, 2025
View reviewed changes
@kevincai kevincai force-pushed the fix-http-json-writer branch from 4d0254f to 8827452 Compare January 3, 2025 05:10
@kevincai kevincai force-pushed the fix-http-json-writer branch from 8827452 to b721556 Compare January 3, 2025 05:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

[BE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/http_result_writer.cpp 4 4 100.00% []

@wyb wyb enabled auto-merge (squash) January 3, 2025 06:35
@wyb wyb merged commit 13be056 into StarRocks:main Jan 3, 2025
49 of 50 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 3, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@kevincai @mergify
[BugFix] fix HttpResultWriter ill-formatted json string (#54590)
042f9d9 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit 13be056)
mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@kevincai @mergify
[BugFix] fix HttpResultWriter ill-formatted json string (#54590)
86cf550 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit 13be056)
@mergify mergify bot mentioned this pull request Jan 3, 2025
Merged
18 tasks
@mergify mergify bot mentioned this pull request Jan 3, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@kevincai @mergify
[BugFix] fix HttpResultWriter ill-formatted json string (#54590)
4c4dfbd 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit 13be056)
@mergify mergify bot mentioned this pull request Jan 3, 2025
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Jan 3, 2025
@mergify @kevincai
[BugFix] fix HttpResultWriter ill-formatted json string (backport #54590
64536a7 
) (#54673)

Co-authored-by: Kevin Cai <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 3, 2025
@mergify @kevincai
[BugFix] fix HttpResultWriter ill-formatted json string (backport #54590
f8c6968 
) (#54674)

Co-authored-by: Kevin Cai <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 3, 2025
@mergify @kevincai
[BugFix] fix HttpResultWriter ill-formatted json string (backport #54590
26bf85f 
) (#54672)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Co-authored-by: Kevin Cai <[email protected]>
@kevincai kevincai deleted the fix-http-json-writer branch January 6, 2025 02:09
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
@kevincai
[BugFix] fix HttpResultWriter ill-formatted json string (StarRocks#54590
944f183 
)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

@LiShuMing LiShuMing LiShuMing approved these changes

@luohaha luohaha luohaha left review comments

Assignees

@kevincai kevincai

Labels
3.2-merged 3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP Request SQL Query Returns Incorrect Results for Same selectItem
5 participants
@kevincai @LiShuMing @luohaha @trueeyu @wyb