Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add partition scan num limit when query internal olap table (backport #53747) #54353

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 26, 2024

Why I'm doing:

when query big size internal olap table with full table scan or scan too many partitions, would cause BE/CN node high load, lead to cluster instability.

What I'm doing:

add a new FE session variable scan_olap_partition_num_limit to limit partition scan num when query internal olap table.
(default value is 0, means no limitation)

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…able (#53747)

Why I'm doing:
when query big size internal olap table with full table scan or scan too many partitions, would cause BE/CN node high load, lead to cluster instability.

What I'm doing:
add a new FE session variable scan_olap_partition_num_limit to limit partition scan num when query internal olap table.
(default value is 0, means no limitation)

Signed-off-by: MatthewH00 <[email protected]>
Signed-off-by: hmx <[email protected]>
(cherry picked from commit a0a25b4)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java
@mergify mergify bot added the conflicts label Dec 26, 2024
Copy link
Contributor Author

mergify bot commented Dec 26, 2024

Cherry-pick of a0a25b4 has failed:

On branch mergify/bp/branch-3.3/pr-53747
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit a0a25b4707.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/OptOlapPartitionPruner.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/PartitionPruneRuleTest.java
	new file:   test/sql/test_olap_partition_scan_limit/R/test_olap_partition_scan_limit
	new file:   test/sql/test_olap_partition_scan_limit/T/test_olap_partition_scan_limit

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) December 26, 2024 02:32
@mergify mergify bot closed this Dec 26, 2024
auto-merge was automatically disabled December 26, 2024 02:32

Pull request was closed

Copy link
Contributor Author

mergify bot commented Dec 26, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
@kevincai kevincai reopened this Dec 26, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) December 26, 2024 08:03
@wanpengfei-git wanpengfei-git merged commit 23036a6 into branch-3.3 Dec 26, 2024
41 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-53747 branch December 26, 2024 08:57
kevincai added a commit to kevincai/starrocks that referenced this pull request Dec 30, 2024
zhangyifan27 pushed a commit to zhangyifan27/starrocks that referenced this pull request Feb 10, 2025
…able (backport StarRocks#53747) (StarRocks#54353)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Co-authored-by: hmx <[email protected]>
Co-authored-by: Kevin Xiaohua Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants