Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Convert the constant value to target type while making kudu predicate. #53936

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Jcnessss
Copy link
Contributor

@Jcnessss Jcnessss commented Dec 13, 2024

Why I'm doing:

For now, the following fails.
select * from (select cast(coin_num as varchar) tmp from kudu.user_3) where tmp = '145';
The error showed below:
coin_num's type isn't [Type: string, Type: varchar], it's double
The error is raised by Kudu client, it builds the predicate according to the type of the literal value we passed in. For this sql, we passed a string '145' but the column type is actually a double, so the error occurred.

What I'm doing:

Cast the constant operator to the target type to get the correct literal value while building the kudu predicate.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@Jcnessss Jcnessss requested a review from a team as a code owner December 13, 2024 09:40
@Jcnessss Jcnessss force-pushed the kudu_predicate branch 2 times, most recently from bfd7f31 to 14e9629 Compare December 18, 2024 09:46
@Jcnessss Jcnessss requested a review from a team as a code owner December 18, 2024 09:46
@Jcnessss Jcnessss force-pushed the kudu_predicate branch 4 times, most recently from aef7c3a to 9484b9a Compare December 19, 2024 03:24
[Enhancement] Convert the constant value to target type while making kudu predicate.

Signed-off-by: Song Jiacheng <[email protected]>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 10 / 11 (90.91%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/kudu/KuduPredicateConverter.java 10 11 90.91% [172]

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Jcnessss
Copy link
Contributor Author

@Seaven @murphyatwork Hi, Could you please help me review this PR?

@murphyatwork murphyatwork merged commit 0a443f0 into StarRocks:main Jan 14, 2025
51 checks passed
@Jcnessss
Copy link
Contributor Author

Thanks for the reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants