Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support push down min/max to scanner for runtime filter with null #53857

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Dec 12, 2024

Why I'm doing:

RuntimeBloomFilter (1, 2, 3, 5, null) will generate one predicate ((xxx>=1 and xxx<=5) or (xxx is null)) and then push down to storage engine.

What I'm doing:

Support push down min/max to scanner for runtime filter with null

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@trueeyu trueeyu requested review from a team as code owners December 12, 2024 01:56
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 121 / 132 (91.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/olap_runtime_range_pruner.hpp 10 15 66.67% [71, 142, 143, 153, 154]
🔵 be/src/exec/olap_scan_prepare.cpp 91 96 94.79% [659, 661, 662, 666, 667]
🔵 be/src/testutil/schema_test_helper.cpp 20 21 95.24% [63]

@meegoo meegoo merged commit f766cc2 into StarRocks:main Dec 12, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants