Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix show table status not check view privilege #53811

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[BugFix] Fix show table status not check view privilege #53811

merged 1 commit into from
Dec 13, 2024

Conversation

HangyuanLiu
Copy link
Contributor

@HangyuanLiu HangyuanLiu commented Dec 11, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@HangyuanLiu HangyuanLiu requested a review from a team as a code owner December 11, 2024 04:04
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 11 / 14 (78.57%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java 5 7 71.43% [1635, 2161]
🔵 com/starrocks/qe/ShowExecutor.java 4 5 80.00% [1859]
🔵 com/starrocks/sql/analyzer/Authorizer.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@andyziye andyziye merged commit 297ae92 into StarRocks:main Dec 13, 2024
49 of 51 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 13, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Dec 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@HangyuanLiu @mergify
[BugFix] Fix show table status not check view privilege (#53811)
d357c6c 
(cherry picked from commit 297ae92)
@mergify mergify bot mentioned this pull request Dec 13, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@HangyuanLiu @mergify
[BugFix] Fix show table status not check view privilege (#53811)
933ffc8 
(cherry picked from commit 297ae92)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java
@mergify mergify bot mentioned this pull request Dec 13, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 13, 2024
@mergify @HangyuanLiu
[BugFix] Fix show table status not check view privilege (backport #53811
ca834d0 
) (#53899)

Co-authored-by: Harbor Liu <[email protected]>
HangyuanLiu added a commit that referenced this pull request Dec 13, 2024
@HangyuanLiu
[BugFix] Fix show table status not check view privilege (#53811)
870842b 
(cherry picked from commit 297ae92)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java
wanpengfei-git pushed a commit that referenced this pull request Dec 13, 2024
@mergify @HangyuanLiu
[BugFix] Fix show table status not check view privilege (backport #53811
5fb66c5 
) (#53900)

Co-authored-by: Harbor Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@Seaven Seaven Seaven approved these changes

Assignees

@HangyuanLiu HangyuanLiu

Labels
3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HangyuanLiu @Seaven @gengjun-git @andyziye