Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][Refactor] optimize array_contains_all/array_contains_seq function (backport #51701) #52190

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 22, 2024

Why I'm doing:

What I'm doing:

optimize the performance of array_contains_all and array_contains_seq, and reduce their implementation complexity from O(m*n) to O(m+n)

basic idea

  1. for array_contains_all, choose the side with less data to build a hash table to speed up the search
  2. for array_contains_seq, it is essentially similar to the string search algorithm. We can use the idea of ​​the KMP algorithm to speed up the search.

Test

Here I use two very simple queries to compare the performance

-- query 1
set @arr0 = array_generate(100000);
set @arr1 = array_generate(200000);
select array_contains_all(@arr1, @arr0);

-- query 2
set @arr0=array_append(array_repeat(1,100000),2);
set @arr1=array_append(array_repeat(1,50000),2);
select array_contains_seq(@arr0,@arr1);
baseline after optimization
query 1 1.66s 0.05s
query 2 1.08s 0.02s

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51701 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

optimize the performance of array_contains_all and array_contains_seq, and reduce their implementation complexity from O(m*n) to O(m+n)

basic idea

  1. for array_contains_all, choose the side with less data to build a hash table to speed up the search
  2. for array_contains_seq, it is essentially similar to the string search algorithm. We can use the idea of ​​the KMP algorithm to speed up the search.

Test

Here I use two very simple queries to compare the performance

-- query 1
set @arr0 = array_generate(100000);
set @arr1 = array_generate(200000);
select array_contains_all(@arr1, @arr0);

-- query 2
set @arr0=array_append(array_repeat(1,100000),2);
set @arr1=array_append(array_repeat(1,50000),2);
select array_contains_seq(@arr0,@arr1);
baseline after optimization
query 1 1.66s 0.05s
query 2 1.08s 0.02s

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…q function (#51701)

Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit ac623b3)

# Conflicts:
#	be/src/column/column_helper.h
@mergify mergify bot added the conflicts label Oct 22, 2024
Copy link
Contributor Author

mergify bot commented Oct 22, 2024

Cherry-pick of ac623b3 has failed:

On branch mergify/bp/branch-3.3/pr-51701
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit ac623b3de5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/column/column_helper.cpp
	modified:   be/src/exprs/array_functions.h
	modified:   be/src/exprs/array_functions.tpp
	modified:   be/src/util/bit_mask.h
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/FunctionSet.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/DecimalV3FunctionAnalyzer.java
	modified:   gensrc/script/functions.py
	modified:   test/sql/test_array_fn/R/test_array_contains
	modified:   test/sql/test_array_fn/T/test_array_contains

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/column/column_helper.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 22, 2024 06:01
@mergify mergify bot closed this Oct 22, 2024
auto-merge was automatically disabled October 22, 2024 06:01

Pull request was closed

Copy link
Contributor Author

mergify bot commented Oct 22, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233 silverbullet233 enabled auto-merge (squash) October 22, 2024 06:24
Copy link

sonarcloud bot commented Oct 22, 2024

@silverbullet233 silverbullet233 merged commit 577013c into branch-3.3 Oct 22, 2024
42 of 43 checks passed
@silverbullet233 silverbullet233 deleted the mergify/bp/branch-3.3/pr-51701 branch October 22, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant