Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] should do mv refresh when force refresh #52081

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[Enhancement] should do mv refresh when force refresh #52081

merged 1 commit into from
Dec 18, 2024

Conversation

kaijianding
Copy link
Contributor

Why I'm doing:

Force mv refresh is useful to handle some abnormal corner case, force keyword should be respected.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions github-actions bot added the 3.3 label Oct 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/mv/MVPCTRefreshRangePartitioner.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit 367311b into StarRocks:main Dec 18, 2024
51 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Dec 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@kaijianding kaijianding deleted the force branch December 18, 2024 05:02
mergify bot pushed a commit that referenced this pull request Dec 18, 2024
@kaijianding @mergify
[Enhancement] should do mv refresh when force refresh (#52081)
a5e5c44 
Signed-off-by: kaijian.ding <[email protected]>
(cherry picked from commit 367311b)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessorJdbcTest.java
#	fe/fe-core/src/test/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessorOlapTest.java
@mergify mergify bot mentioned this pull request Dec 18, 2024
Merged
13 tasks
wanpengfei-git pushed a commit that referenced this pull request Jan 7, 2025
@mergify @kaijianding @LiShuMing
[Enhancement] should do mv refresh when force refresh (backport #52081)…
a228101 
… (#54056)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: kaijianding <[email protected]>
Co-authored-by: shuming.li <[email protected]>
zhangyifan27 pushed a commit to zhangyifan27/starrocks that referenced this pull request Feb 10, 2025
@mergify @kaijianding @LiShuMing
[Enhancement] should do mv refresh when force refresh (backport StarR…
0cfb2e5 
…ocks#52081) (StarRocks#54056)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: kaijianding <[email protected]>
Co-authored-by: shuming.li <[email protected]>
smartlxh pushed a commit to smartlxh/starrocks that referenced this pull request Feb 24, 2025
@kaijianding @LiShuMing @miomiocat
[Backport][Enhancement] should do mv refresh when force refresh (back…
8c4e3fd 
…port StarRocks#52081) (StarRocks#54056)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: kaijianding <[email protected]>
Co-authored-by: shuming.li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@LiShuMing LiShuMing LiShuMing approved these changes

Assignees

@kaijianding kaijianding

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaijianding @satanson @LiShuMing @kangkaisen