Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix incorrect materialized index row count #51944

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

kaijianding
Copy link
Contributor

Why I'm doing:

Fix incorrect mv row count which introduced in #50668

What I'm doing:

The MaterializedIndex object is different in every physicalPartition, but with the same index.getId(), so the indexRowCountMap.put(index.getId(), indexRowCount) will overwrite previous mv partition's row count with the later partition's row count

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/TabletStatMgr.java 5 5 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@murphyatwork murphyatwork enabled auto-merge (squash) October 17, 2024 02:59
@murphyatwork murphyatwork merged commit 1df36e4 into StarRocks:main Oct 17, 2024
50 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 17, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 17, 2024
Copy link
Contributor

mergify bot commented Oct 17, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 17, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 17, 2024
Signed-off-by: kaijian.ding <[email protected]>
(cherry picked from commit 1df36e4)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/TabletStatMgr.java
mergify bot pushed a commit that referenced this pull request Oct 17, 2024
Signed-off-by: kaijian.ding <[email protected]>
(cherry picked from commit 1df36e4)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/TabletStatMgr.java
dirtysalt pushed a commit to dirtysalt/starrocks that referenced this pull request Oct 18, 2024
wanpengfei-git pushed a commit that referenced this pull request Oct 19, 2024
…52018)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: kaijianding <[email protected]>
Co-authored-by: shuming.li <[email protected]>
@kaijianding kaijianding deleted the mv_rowcount branch October 21, 2024 09:27
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2024
…52019)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: kaijianding <[email protected]>
Co-authored-by: shuming.li <[email protected]>
@wyb wyb changed the title [BugFix] Fix incorrect materialized view row count [BugFix] Fix incorrect materialized index row count Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants