-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]when hash table has no conflict no need check next #51943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zombee0 <[email protected]>
trueeyu
previously approved these changes
Oct 16, 2024
Signed-off-by: zombee0 <[email protected]>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 12 / 12 (100.00%) file detail
|
DorianZheng
approved these changes
Oct 17, 2024
stdpain
approved these changes
Oct 17, 2024
dirtysalt
pushed a commit
to dirtysalt/starrocks
that referenced
this pull request
Oct 18, 2024
…Rocks#51943) Signed-off-by: zombee0 <[email protected]>
ZiheLiu
pushed a commit
to ZiheLiu/starrocks
that referenced
this pull request
Oct 31, 2024
…Rocks#51943) Signed-off-by: zombee0 <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…Rocks#51943) Signed-off-by: zombee0 <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
when used_bucket == row_count, there is no conflict for hash value, so we don't need to check next.
we added a branch to check used_bucket == row_count, but it's predictable.
we don't need to check next, that reduces branch,
and no need to access memory, which means less cache miss especially when right table is large.
tpch sf1000,
select count(*) from lineitem join[broadcast] supplier on cast(l_suppkey as int) = cast(s_suppkey as int) where s_suppkey < 4000000;
before:
63s
after:
53s
select count(*) from lineitem join[broadcast] supplier on cast(l_suppkey as int) = cast(s_suppkey as int) where s_suppkey < 2000000;
before:
58s
after:
47s
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: