-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix replaying AlterJob NPE Bug (backport #50100) #50107
Conversation
Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit f721fd4) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/alter/LakeTableAsyncFastSchemaChangeJob.java # fe/fe-core/src/main/java/com/starrocks/alter/LakeTableSchemaChangeJob.java # fe/fe-core/src/main/java/com/starrocks/alter/OnlineOptimizeJobV2.java # fe/fe-core/src/main/java/com/starrocks/alter/RollupJobV2.java
Cherry-pick of f721fd4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
Signed-off-by: gengjun-git <[email protected]>
Quality Gate passedIssues Measures |
Why I'm doing:
What I'm doing:
The root cause of this bug is that the span attribute is null after restarting FE, causing NPE to be thrown when calling span. Add a default constructor to each subclass of AlterJobV2 so that span will be set to a default value after deserialization.
Fixes #50101
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #50100 done by [Mergify](https://mergify.com). ## Why I'm doing:
What I'm doing:
The root cause of this bug is that the span attribute is null after restarting FE, causing NPE to be thrown when calling span. Add a default constructor to each subclass of AlterJobV2 so that span will be set to a default value after deserialization.
Fixes #50101
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: