[Enhancement] Support configurable hll_sketch and optimize hll_sketch performance (backport #48939) #50008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
… performance (#48939) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 89a6b77) # Conflicts: # be/src/exprs/agg/factory/aggregate_resolver_approx.cpp # be/src/exprs/agg/hll_sketch.h # be/src/types/constexpr.h # be/src/types/hll.cpp # be/src/types/hll.h # fe/fe-core/src/main/java/com/starrocks/catalog/FunctionSet.java # fe/fe-core/src/main/java/com/starrocks/sql/analyzer/FunctionAnalyzer.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/PreAggregateTurnOnRule.java
|
Cherry-pick of 89a6b77 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
24 tasks
|
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
HLL_SKETCHis very useful for high precision ndv compute. The PR(#20836) has supported hll_sketch aggregation, but there are some limitions:precisionandhll_typecannot be configurable for different scences.merge:mergefunction is heavy since it will copyhllsketchintohll_unioneach call:What I'm doing:
ds_hll_count_distinctto be better syntax meanings(original function name is also kept either)hll_sketchwith differentprecisionandhll_type:mergeperformance by usinghll_unionas state rather thanhllsketchto avoid copying inmergecall.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #48939 done by [Mergify](https://mergify.com). ## Why I'm doing: `HLL_SKETCH` is very useful for high precision ndv compute. The PR(https://github.com//pull/20836) has supported hll_sketch aggregation, but there are some limitions: 1. HLLSketch's `precision` and `hll_type` cannot be configurable for different scences. 2. There is a performance throttle for high cardinality compute in `merge`:
mergefunction is heavy since it will copyhllsketchintohll_unioneach call:What I'm doing:
ds_hll_count_distinctto be better syntax meanings(original function name is also kept either)hll_sketchwith differentprecisionandhll_type:mergeperformance by usinghll_unionas state rather thanhllsketchto avoid copying inmergecall.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: