[Enhancement] Log the content of journal entity on replay failure #46011

nshangyiming · 2024-05-21T09:20:01Z

Also we shouldn't catch the exception when replaying create table failed,
This will cause the following log replay failure and hard to address the root cause.

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: Dejun Xia <[email protected]>

fe/fe-core/src/main/java/com/starrocks/server/GlobalStateMgr.java

sonarcloud · 2024-05-21T09:27:34Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-05-21T11:05:31Z

[FE Incremental Coverage Report]

❌ fail : 1 / 12 (08.33%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/server/LocalMetastore.java	0	1	00.00%	[2431]
🔵	com/starrocks/server/GlobalStateMgr.java	0	10	00.00%	[1848, 1849, 1856, 1857, 1896, 1897, 1899, 1901, 1902, 1904]
🔵	com/starrocks/persist/metablock/SRMetaBlockReader.java	1	1	100.00%	[]

github-actions · 2024-05-21T11:06:11Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-05-21T12:18:59Z

@Mergifyio backport branch-3.3

github-actions · 2024-05-21T12:19:00Z

@Mergifyio backport branch-3.2

github-actions · 2024-05-21T12:19:01Z

@Mergifyio backport branch-3.1

mergify · 2024-05-21T12:19:02Z

backport branch-3.3

✅ Backports have been created

#46025 [Enhancement] Log the content of journal entity on replay failure (backport #46011) has been created for branch branch-3.3

github-actions · 2024-05-21T12:19:03Z

@Mergifyio backport branch-3.0

github-actions · 2024-05-21T12:19:04Z

@Mergifyio backport branch-2.5

mergify · 2024-05-21T12:19:07Z

backport branch-3.2

✅ Backports have been created

#46026 [Enhancement] Log the content of journal entity on replay failure (backport #46011) has been created for branch branch-3.2

mergify · 2024-05-21T12:19:08Z

backport branch-3.1

✅ Backports have been created

#46027 [Enhancement] Log the content of journal entity on replay failure (backport #46011) has been created for branch branch-3.1

mergify · 2024-05-21T12:19:10Z

backport branch-3.0

✅ Backports have been created

#46028 [Enhancement] Log the content of journal entity on replay failure (backport #46011) has been created for branch branch-3.0 but encountered conflicts

mergify · 2024-05-21T12:19:11Z

backport branch-2.5

✅ Backports have been created

#46029 [Enhancement] Log the content of journal entity on replay failure (backport #46011) has been created for branch branch-2.5 but encountered conflicts

…6011) Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit 759125c)

…6011) Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit 759125c) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/server/GlobalStateMgr.java # fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java

…6011) Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit 759125c) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/persist/metablock/SRMetaBlockReader.java # fe/fe-core/src/main/java/com/starrocks/server/GlobalStateMgr.java # fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java

…ckport #46011) (#46027) Co-authored-by: yiming <[email protected]>

…ckport #46011) (#46025) Co-authored-by: yiming <[email protected]>

…6011) Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit 759125c)

…ckport #46011) (#46029) Signed-off-by: yiming <[email protected]> Co-authored-by: yiming <[email protected]>

…ckport #46011) (#46028) Signed-off-by: yiming <[email protected]> Co-authored-by: yiming <[email protected]>

…ckport #46011) (#46026) Signed-off-by: yiming <[email protected]> Co-authored-by: yiming <[email protected]>

[Enhancement] Log the content of journal entity on replay failure

73028fc

Signed-off-by: Dejun Xia <[email protected]>

nshangyiming requested a review from a team as a code owner May 21, 2024 09:20

github-actions bot added 3.3 3.2 3.1 3.0 2.5 labels May 21, 2024

mergify bot assigned nshangyiming May 21, 2024

starrocks-cr bot reviewed May 21, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/server/GlobalStateMgr.java Show resolved Hide resolved

HangyuanLiu approved these changes May 21, 2024

View reviewed changes

gengjun-git approved these changes May 21, 2024

View reviewed changes

nshangyiming enabled auto-merge (squash) May 21, 2024 12:11

wanpengfei-git disabled auto-merge May 21, 2024 12:18

wanpengfei-git merged commit 759125c into StarRocks:main May 21, 2024
64 of 65 checks passed

github-actions bot removed the 3.3 label May 21, 2024

github-actions bot removed the 3.2 label May 21, 2024

github-actions bot removed the 3.1 label May 21, 2024

github-actions bot removed the 3.0 label May 21, 2024

github-actions bot removed the 2.5 label May 21, 2024

mergify bot pushed a commit that referenced this pull request May 21, 2024

[Enhancement] Log the content of journal entity on replay failure (#4…

0cf5bb0

…6011) Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit 759125c)

mergify bot mentioned this pull request May 21, 2024

[Enhancement] Log the content of journal entity on replay failure (backport #46011) #46025

Merged

42 tasks

mergify bot pushed a commit that referenced this pull request May 21, 2024

[Enhancement] Log the content of journal entity on replay failure (#4…

1658aeb

…6011) Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit 759125c)

mergify bot pushed a commit that referenced this pull request May 21, 2024

[Enhancement] Log the content of journal entity on replay failure (#4…

59d2c52

…6011) Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit 759125c)

This was referenced May 21, 2024

[Enhancement] Log the content of journal entity on replay failure (backport #46011) #46026

Merged

[Enhancement] Log the content of journal entity on replay failure (backport #46011) #46027

Merged

mergify bot mentioned this pull request May 21, 2024

[Enhancement] Log the content of journal entity on replay failure (backport #46011) #46028

Merged

42 tasks

mergify bot mentioned this pull request May 21, 2024

[Enhancement] Log the content of journal entity on replay failure (backport #46011) #46029

Merged

42 tasks

wanpengfei-git pushed a commit that referenced this pull request May 21, 2024

[Enhancement] Log the content of journal entity on replay failure (ba…

c012f33

…ckport #46011) (#46027) Co-authored-by: yiming <[email protected]>

github-actions bot added the 3.1-merged label May 21, 2024

wanpengfei-git pushed a commit that referenced this pull request May 21, 2024

[Enhancement] Log the content of journal entity on replay failure (ba…

366e07c

…ckport #46011) (#46025) Co-authored-by: yiming <[email protected]>

github-actions bot added the 3.3-merged label May 21, 2024

nshangyiming added a commit that referenced this pull request May 22, 2024

[Enhancement] Log the content of journal entity on replay failure (#4…

c4229b9

…6011) Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit 759125c)

wanpengfei-git pushed a commit that referenced this pull request May 23, 2024

[Enhancement] Log the content of journal entity on replay failure (ba…

bfdb05d

…ckport #46011) (#46029) Signed-off-by: yiming <[email protected]> Co-authored-by: yiming <[email protected]>

github-actions bot added the 2.5-merged label May 23, 2024

wanpengfei-git pushed a commit that referenced this pull request May 23, 2024

[Enhancement] Log the content of journal entity on replay failure (ba…

dddc16f

…ckport #46011) (#46028) Signed-off-by: yiming <[email protected]> Co-authored-by: yiming <[email protected]>

github-actions bot added the 3.0-merged label May 23, 2024

wanpengfei-git pushed a commit that referenced this pull request May 27, 2024

[Enhancement] Log the content of journal entity on replay failure (ba…

f147d36

…ckport #46011) (#46026) Signed-off-by: yiming <[email protected]> Co-authored-by: yiming <[email protected]>

github-actions bot added the 3.2-merged label May 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Log the content of journal entity on replay failure #46011

[Enhancement] Log the content of journal entity on replay failure #46011

nshangyiming commented May 21, 2024 •

edited

Loading

sonarcloud bot commented May 21, 2024

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

mergify bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

mergify bot commented May 21, 2024 •

edited

Loading

mergify bot commented May 21, 2024 •

edited

Loading

mergify bot commented May 21, 2024 •

edited

Loading

mergify bot commented May 21, 2024 •

edited

Loading

[Enhancement] Log the content of journal entity on replay failure #46011

[Enhancement] Log the content of journal entity on replay failure #46011

Conversation

nshangyiming commented May 21, 2024 • edited Loading

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarcloud bot commented May 21, 2024

Quality Gate passed

github-actions bot commented May 21, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented May 21, 2024

[BE Incremental Coverage Report]

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

mergify bot commented May 21, 2024 • edited Loading

✅ Backports have been created

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

mergify bot commented May 21, 2024 • edited Loading

✅ Backports have been created

mergify bot commented May 21, 2024 • edited Loading

✅ Backports have been created

mergify bot commented May 21, 2024 • edited Loading

✅ Backports have been created

mergify bot commented May 21, 2024 • edited Loading

✅ Backports have been created

nshangyiming commented May 21, 2024 •

edited

Loading

mergify bot commented May 21, 2024 •

edited

Loading

mergify bot commented May 21, 2024 •

edited

Loading

mergify bot commented May 21, 2024 •

edited

Loading

mergify bot commented May 21, 2024 •

edited

Loading

mergify bot commented May 21, 2024 •

edited

Loading