Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Consistency checker should use local time zone #45749

Merged
merged 1 commit into from
May 17, 2024
Merged

[BugFix] Consistency checker should use local time zone #45749

merged 1 commit into from
May 17, 2024

Conversation

nshangyiming
Copy link
Contributor

Fixes #45748

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@nshangyiming nshangyiming requested a review from a team as a code owner May 16, 2024 10:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 5 / 8 (62.50%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/consistency/ConsistencyChecker.java 5 8 62.50% [120, 121, 123]

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@nshangyiming nshangyiming enabled auto-merge (squash) May 17, 2024 01:46
@andyziye andyziye disabled auto-merge May 17, 2024 07:20
@andyziye andyziye merged commit 78c5593 into StarRocks:main May 17, 2024
52 of 53 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label May 17, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label May 17, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label May 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 17, 2024
@nshangyiming @mergify
[BugFix] Consistency checker should use local time zone (#45749)
ef70e14 
Signed-off-by: Dejun Xia <[email protected]>
(cherry picked from commit 78c5593)
mergify bot pushed a commit that referenced this pull request May 17, 2024
@nshangyiming @mergify
[BugFix] Consistency checker should use local time zone (#45749)
3c342bb 
Signed-off-by: Dejun Xia <[email protected]>
(cherry picked from commit 78c5593)
@mergify mergify bot mentioned this pull request May 17, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request May 17, 2024
@nshangyiming @mergify
[BugFix] Consistency checker should use local time zone (#45749)
d1b4031 
Signed-off-by: Dejun Xia <[email protected]>
(cherry picked from commit 78c5593)
This was referenced May 17, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 17, 2024
@nshangyiming @mergify
[BugFix] Consistency checker should use local time zone (#45749)
e806280 
Signed-off-by: Dejun Xia <[email protected]>
(cherry picked from commit 78c5593)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/consistency/ConsistencyChecker.java
mergify bot pushed a commit that referenced this pull request May 17, 2024
@nshangyiming @mergify
[BugFix] Consistency checker should use local time zone (#45749)
8130d6f 
Signed-off-by: Dejun Xia <[email protected]>
(cherry picked from commit 78c5593)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/consistency/ConsistencyChecker.java
This was referenced May 17, 2024
Merged
Merged
node pushed a commit to vivo/starrocks that referenced this pull request May 17, 2024
@nshangyiming @node
[BugFix] Consistency checker should use local time zone (StarRocks#45749
3e1b7e2 
)

Signed-off-by: Dejun Xia <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request May 17, 2024
@mergify @nshangyiming
[BugFix] Consistency checker should use local time zone (backport #45749
b8e3454 
) (#45822)

Co-authored-by: yiming <[email protected]>
nshangyiming added a commit that referenced this pull request May 17, 2024
@nshangyiming
[BugFix] Consistency checker should use local time zone (#45749)
763e43b 
Signed-off-by: Dejun Xia <[email protected]>
(cherry picked from commit 78c5593)
wanpengfei-git pushed a commit that referenced this pull request May 17, 2024
@mergify @nshangyiming
[BugFix] Consistency checker should use local time zone (backport #45749
ae99244 
) (#45825)

Signed-off-by: yiming <[email protected]>
Co-authored-by: yiming <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request May 17, 2024
@mergify @nshangyiming
[BugFix] Consistency checker should use local time zone (backport #45749
58177bb 
) (#45821)

Co-authored-by: yiming <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request May 17, 2024
@mergify @nshangyiming
[BugFix] Consistency checker should use local time zone (backport #45749
4fbb6cf 
) (#45824)

Signed-off-by: yiming <[email protected]>
Co-authored-by: yiming <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request May 17, 2024
@mergify @nshangyiming
[BugFix] Consistency checker should use local time zone (backport #45749
5be4e1c 
) (#45823)

Co-authored-by: yiming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@gengjun-git gengjun-git gengjun-git approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

Assignees

@nshangyiming nshangyiming

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistency checker's start/end time should use local time zone
4 participants
@nshangyiming @HangyuanLiu @gengjun-git @andyziye