[Enhancement] Migrate part of db lock to table lock in SchemaChange #43907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| @@ -2159,7 +2163,7 @@ public ShowResultSet visitShowIndexStatement(ShowIndexStmt statement, ConnectCon | |||
| // do nothing | |||
| } | |||
| } finally { | |||
| locker.unLockDatabase(db, LockType.READ); | |||
| locker.unLockTablesWithIntensiveDbLock(db, Lists.newArrayList(table.getId()), LockType.READ); | |||
| } | |||
| return new ShowResultSet(statement.getMetaData(), rows); | |||
| } | |||
There was a problem hiding this comment.
The most risky bug in this code is:
Potential null pointer exception when using the table variable.
You can modify the code like this:
locker.lockTablesWithIntensiveDbLock(db, table != null ? Lists.newArrayList(table.getId()) : Collections.emptyList(), LockType.READ);
try {
// Existing try block code remains unchanged
} finally {
locker.unLockTablesWithIntensiveDbLock(db, table != null ? Lists.newArrayList(table.getId()) : Collections.emptyList(), LockType.READ);
}This modification ensures that the code checks if the table variable is null before attempting to use it, avoiding a potential NullPointerException.
|
HangyuanLiu
force-pushed
the
show-exe-lock
branch
3 times, most recently
from
7c46143 to
7e28d4d
Compare
HangyuanLiu
force-pushed
the
show-exe-lock
branch
from
7e28d4d to
55a2603
Compare
Signed-off-by: HangyuanLiu <[email protected]>
HangyuanLiu
force-pushed
the
show-exe-lock
branch
from
55a2603 to
8af7420
Compare
HangyuanLiu
changed the title
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 170 / 219 (77.63%) file detail
|
Astralidea
approved these changes
Jul 10, 2024
wyb
approved these changes
Jul 11, 2024
|
|
||
| MaterializedView oldMaterializedView = (MaterializedView) db.getTable(id); | ||
| if (oldMaterializedView == null) { | ||
| LOG.warn("Ignore change materialized view refresh scheme log because table:" + id + "is null"); |
There was a problem hiding this comment.
Suggested change
| LOG.warn("Ignore change materialized view refresh scheme log because table:" + id + "is null"); | |
| LOG.warn("Ignore change materialized view refresh scheme log because table:" + id + " is null"); |
nshangyiming
approved these changes
Jul 12, 2024
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
…43907) Signed-off-by: HangyuanLiu <[email protected]> (cherry picked from commit d8649e3)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 12, 2024
…backport #43907) (#48294) Co-authored-by: Harbor Liu <[email protected]>
HangyuanLiu
added a commit
that referenced
this pull request
Jul 23, 2024
…43907) Signed-off-by: HangyuanLiu <[email protected]>
HangyuanLiu
added a commit
that referenced
this pull request
Jul 23, 2024
…43907) Signed-off-by: HangyuanLiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: