-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support for FE division of execution groups #42583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdpain
force-pushed
the
group_execution_fe
branch
2 times, most recently
from
March 14, 2024 02:48
d3a111b
to
884ab25
Compare
stdpain
force-pushed
the
group_execution_fe
branch
from
March 14, 2024 03:25
884ab25
to
c77ed2d
Compare
Divide the execution group when building the planfragment. For colocate join/agg put into execution group. Nodes in the same execution group can create more operators. Signed-off-by: stdpain <[email protected]>
stdpain
force-pushed
the
group_execution_fe
branch
from
March 14, 2024 07:34
c77ed2d
to
d35b4ef
Compare
Seaven
previously approved these changes
Mar 18, 2024
ZiheLiu
reviewed
Mar 18, 2024
...ore/src/main/java/com/starrocks/qe/scheduler/assignment/LocalFragmentAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java
Outdated
Show resolved
Hide resolved
ZiheLiu
previously approved these changes
Mar 18, 2024
Signed-off-by: stdpain <[email protected]>
stdpain
force-pushed
the
group_execution_fe
branch
from
March 18, 2024 08:01
a7bc1f2
to
035238e
Compare
Quality Gate passedIssues Measures |
ZiheLiu
approved these changes
Mar 18, 2024
ZiheLiu
approved these changes
Mar 18, 2024
[FE Incremental Coverage Report]✅ pass : 248 / 286 (86.71%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Mar 18, 2024
23 tasks
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Apr 18, 2024
Signed-off-by: stdpain <[email protected]> Signed-off-by: stdpain <[email protected]>
24 tasks
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Apr 19, 2024
Signed-off-by: stdpain <[email protected]>
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Apr 19, 2024
Signed-off-by: stdpain <[email protected]>
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Apr 19, 2024
Signed-off-by: stdpain <[email protected]>
stdpain
added a commit
that referenced
this pull request
Apr 19, 2024
Signed-off-by: stdpain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Divide the execution group when building the planfragment. For colocate join/agg put into execution group. Nodes in the same execution group can create more operators.
sesssion variables:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: