Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support for FE division of execution groups #42583

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Mar 13, 2024

Why I'm doing:

Divide the execution group when building the planfragment. For colocate join/agg put into execution group. Nodes in the same execution group can create more operators.

sesssion variables:

enable_group_execution: whether to enable group execution
group_execution_group_scale: Controls the number of groups to dismantle. The number of groups to split is min(dop x scale, group_nums, max_group_nums)
group_execution_max_groups: max group nums

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stdpain stdpain requested review from a team as code owners March 13, 2024 13:18
@stdpain stdpain force-pushed the group_execution_fe branch 2 times, most recently from d3a111b to 884ab25 Compare March 14, 2024 02:48
@stdpain stdpain enabled auto-merge (squash) March 14, 2024 02:48
@stdpain stdpain force-pushed the group_execution_fe branch from 884ab25 to c77ed2d Compare March 14, 2024 03:25
Divide the execution group when building the planfragment. For colocate
join/agg put into execution group. Nodes in the same execution group can
create more operators.

Signed-off-by: stdpain <[email protected]>
@stdpain stdpain force-pushed the group_execution_fe branch from c77ed2d to d35b4ef Compare March 14, 2024 07:34
Seaven
Seaven previously approved these changes Mar 18, 2024
ZiheLiu
ZiheLiu previously approved these changes Mar 18, 2024
Signed-off-by: stdpain <[email protected]>
Copy link

Copy link

[FE Incremental Coverage Report]

pass : 248 / 286 (86.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/scheduler/assignment/LocalFragmentAssignmentStrategy.java 19 29 65.52% [201, 202, 203, 204, 205, 257, 258, 259, 260, 261]
🔵 com/starrocks/planner/PlanFragment.java 23 34 67.65% [477, 478, 479, 480, 481, 482, 586, 587, 588, 589, 590]
🔵 com/starrocks/qe/SessionVariable.java 6 8 75.00% [1432, 1436]
🔵 com/starrocks/planner/ExecGroup.java 29 36 80.56% [88, 89, 90, 91, 92, 93, 94]
🔵 com/starrocks/planner/JoinNode.java 8 10 80.00% [248, 250]
🔵 com/starrocks/planner/ExecGroupId.java 4 5 80.00% [34]
🔵 com/starrocks/planner/ExecGroupSets.java 13 15 86.67% [48, 49]
🔵 com/starrocks/planner/RuntimeFilterDescription.java 9 10 90.00% [202]
🔵 com/starrocks/sql/plan/PlanFragmentBuilder.java 86 88 97.73% [577, 1554]
🔵 com/starrocks/planner/AnalyticEvalNode.java 3 3 100.00% []
🔵 com/starrocks/planner/AggregationNode.java 3 3 100.00% []
🔵 com/starrocks/planner/SortNode.java 2 2 100.00% []
🔵 com/starrocks/planner/RuntimeFilterPushDownContext.java 10 10 100.00% []
🔵 com/starrocks/planner/SetOperationNode.java 3 3 100.00% []
🔵 com/starrocks/planner/ExchangeNode.java 5 5 100.00% []
🔵 com/starrocks/planner/DecodeNode.java 4 4 100.00% []
🔵 com/starrocks/sql/plan/ExecPlan.java 4 4 100.00% []
🔵 com/starrocks/planner/PlanNode.java 11 11 100.00% []
🔵 com/starrocks/planner/NestLoopJoinNode.java 2 2 100.00% []
🔵 com/starrocks/planner/ProjectNode.java 4 4 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stdpain stdpain merged commit 2236631 into StarRocks:main Mar 18, 2024
45 of 48 checks passed
@stdpain stdpain mentioned this pull request Mar 25, 2024
23 tasks
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Apr 18, 2024
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Apr 19, 2024
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Apr 19, 2024
stdpain added a commit to stdpain/starrocks-2 that referenced this pull request Apr 19, 2024
stdpain added a commit that referenced this pull request Apr 19, 2024
@stdpain stdpain deleted the group_execution_fe branch December 4, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants