Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Get partitions by batch of size 5k per RPC #19241

Merged
merged 2 commits into from
Mar 9, 2023
Merged

[Enhancement] Get partitions by batch of size 5k per RPC #19241

merged 2 commits into from
Mar 9, 2023

Conversation

letian-jiang
Copy link
Contributor

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #

Problem Summary(Required) ：

  • Get partitions by batch of size 5k per RPC
  • Set max_hive_partitions_per_rpc = 5000

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@letian-jiang
Copy link
Contributor Author

run starrocks_admit_test

@letian-jiang letian-jiang force-pushed the get-partitions-by-batch branch from 73be4ec to e44b9b3 Compare March 9, 2023 02:54
@github-actions github-actions bot removed the be-build label Mar 9, 2023
@letian-jiang letian-jiang force-pushed the get-partitions-by-batch branch from e44b9b3 to e86aa2b Compare March 9, 2023 02:56
@github-actions github-actions bot removed the be-build label Mar 9, 2023
@letian-jiang
update
65c6b54 
Signed-off-by: Letian Jiang <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 8 / 8 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/hive/HiveMetastore.java 7 7 100.00% []
🔵 com/starrocks/common/Config.java 1 1 100.00% []

@letian-jiang
Copy link
Contributor Author

run starrocks_admit_test

@Youngwb Youngwb merged commit 7401b49 into StarRocks:main Mar 9, 2023
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Mar 9, 2023
@github-actions github-actions bot removed the be-build label Mar 9, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@letian-jiang letian-jiang deleted the get-partitions-by-batch branch March 9, 2023 11:52
@letian-jiang
Copy link
Contributor Author

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@letian-jiang
Copy link
Contributor Author

@Mergifyio backport branch-2.5

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 9, 2023
@letian-jiang @mergify
[Enhancement] Get partitions by batch of size 5k per RPC (#19241)
bd43dd1 
(cherry picked from commit 7401b49)
@mergify mergify bot mentioned this pull request Mar 9, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 9, 2023
@letian-jiang @mergify
[Enhancement] Get partitions by batch of size 5k per RPC (#19241)
84a4ecc 
(cherry picked from commit 7401b49)
@mergify mergify bot mentioned this pull request Mar 9, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Mar 9, 2023
@letian-jiang @wanpengfei-git
[Enhancement] Get partitions by batch of size 5k per RPC (#19241)
151b99a 
(cherry picked from commit 7401b49)
wanpengfei-git pushed a commit that referenced this pull request Mar 10, 2023
@letian-jiang @wanpengfei-git
[Enhancement] Get partitions by batch of size 5k per RPC (#19241)
69a59b7 
(cherry picked from commit 7401b49)
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Mar 19, 2023
@letian-jiang @Jay-ju
[Enhancement] Get partitions by batch of size 5k per RPC (StarRocks#1…
31e7f72 
…9241)
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Mar 28, 2023
@letian-jiang @abc982627271
[Enhancement] Get partitions by batch of size 5k per RPC (StarRocks#1…
10bf056 
…9241)
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@letian-jiang
[Enhancement] Get partitions by batch of size 5k per RPC (StarRocks#1…
c460fe7 
…9241)
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
@letian-jiang @abc982627271
[Enhancement] Get partitions by batch of size 5k per RPC (StarRocks#1…
a649e89 
…9241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smith-Cruise Smith-Cruise Smith-Cruise left review comments

@dirtysalt dirtysalt dirtysalt left review comments

@stephen-shelby stephen-shelby stephen-shelby approved these changes

@Youngwb Youngwb Youngwb approved these changes

Assignees

@letian-jiang letian-jiang

Labels
Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@letian-jiang @wanpengfei-git @dirtysalt @Youngwb @Smith-Cruise @stephen-shelby