[Enhancement] Reduce S3 headObject requests in lake tablet GC #19148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduzh
force-pushed
the
enhancement/iterate_dir2
branch
2 times, most recently
from
33a10fa to
4ad2a83
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
sduzh
force-pushed
the
enhancement/iterate_dir2
branch
from
4ad2a83 to
4832630
Compare
sduzh
changed the title
|
run starrocks_admit_test |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sduzh
force-pushed
the
enhancement/iterate_dir2
branch
from
4832630 to
ceaf16f
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
imay
reviewed
Mar 8, 2023
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run starrocks_admit_test |
|
run starrocks_admit_test |
Add a new FileSystem interface iterate_dir2() for getting the file modification time while traversing the directory to avoid additional `FileSystem::get_file_modified_time()` calls. In fact, this PR will not have any optimization, because the new interface is not really implemented in the StarletFilesystem, another PR is needed. Signed-off-by: sduzh <[email protected]>
sduzh
force-pushed
the
enhancement/iterate_dir2
branch
from
77212e0 to
12938b9
Compare
|
run starrocks_admit_test |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Kudos, SonarCloud Quality Gate passed!
|
imay
approved these changes
Mar 9, 2023
kevincai
approved these changes
Mar 9, 2023
|
run starrocks_admit_test |
|
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
Add a new FileSystem interface iterate_dir2() for getting the file modification time while traversing the directory to avoid additional `FileSystem::get_file_modified_time()` calls. In fact, this PR will not have any optimization, because the new interface is not really implemented in the StarletFilesystem, another PR is needed. Signed-off-by: sduzh <[email protected]> (cherry picked from commit c301d2d)
sduzh
added a commit
that referenced
this pull request
Mar 10, 2023
Add a new FileSystem interface iterate_dir2() for getting the file modification time while traversing the directory to avoid additional `FileSystem::get_file_modified_time()` calls. In fact, this PR will not have any optimization, because the new interface is not really implemented in the StarletFilesystem, another PR is needed. Signed-off-by: sduzh <[email protected]> (cherry picked from commit c301d2d)
sduzh
added a commit
that referenced
this pull request
Mar 10, 2023
Add a new FileSystem interface iterate_dir2() for getting the file modification time while traversing the directory to avoid additional `FileSystem::get_file_modified_time()` calls. In fact, this PR will not have any optimization, because the new interface is not really implemented in the StarletFilesystem, another PR is needed. Signed-off-by: sduzh <[email protected]> (cherry picked from commit c301d2d)
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 10, 2023
Add a new FileSystem interface iterate_dir2() for getting the file modification time while traversing the directory to avoid additional `FileSystem::get_file_modified_time()` calls. In fact, this PR will not have any optimization, because the new interface is not really implemented in the StarletFilesystem, another PR is needed. Signed-off-by: sduzh <[email protected]> (cherry picked from commit c301d2d)
Jay-ju
pushed a commit
to Jay-ju/starrocks
that referenced
this pull request
Mar 19, 2023
…ocks#19148) Add a new FileSystem interface iterate_dir2() for getting the file modification time while traversing the directory to avoid additional `FileSystem::get_file_modified_time()` calls. In fact, this PR will not have any optimization, because the new interface is not really implemented in the StarletFilesystem, another PR is needed. Signed-off-by: sduzh <[email protected]>
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Mar 28, 2023
…ocks#19148) Add a new FileSystem interface iterate_dir2() for getting the file modification time while traversing the directory to avoid additional `FileSystem::get_file_modified_time()` calls. In fact, this PR will not have any optimization, because the new interface is not really implemented in the StarletFilesystem, another PR is needed. Signed-off-by: sduzh <[email protected]>
numbernumberone
pushed a commit
to numbernumberone/starrocks
that referenced
this pull request
May 31, 2023
…ocks#19148) Add a new FileSystem interface iterate_dir2() for getting the file modification time while traversing the directory to avoid additional `FileSystem::get_file_modified_time()` calls. In fact, this PR will not have any optimization, because the new interface is not really implemented in the StarletFilesystem, another PR is needed. Signed-off-by: sduzh <[email protected]>
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 5, 2023
…ocks#19148) Add a new FileSystem interface iterate_dir2() for getting the file modification time while traversing the directory to avoid additional `FileSystem::get_file_modified_time()` calls. In fact, this PR will not have any optimization, because the new interface is not really implemented in the StarletFilesystem, another PR is needed. Signed-off-by: sduzh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new FileSystem interface
iterate_dir2()for getting the file modification time while traversing the directory to avoid additionalFileSystem::get_file_modified_time()calls.In fact, this PR will not have any optimization, because the new interface is not really implemented in the StarletFilesystem,, another PR is needed.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
Checklist:
Bugfix cherry-pick branch check: