[BugFix] Fix ASAN crash when push null chunk to accumulator (#19270)

Signed-off-by: stdpain <[email protected]> (cherry picked from commit 745e318) Signed-off-by: stdpain <[email protected]>
StarRocks · Mar 10, 2023 · 67bedc9 · 67bedc9
1 parent 69a59b7
commit 67bedc9
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/be/src/exec/pipeline/aggregate/sorted_aggregate_streaming_sink_operator.cpp b/be/src/exec/pipeline/aggregate/sorted_aggregate_streaming_sink_operator.cpp
@@ -50,10 +50,15 @@ Status SortedAggregateStreamingSinkOperator::set_finishing(RuntimeState* state)
     _is_finished = true;
     ASSIGN_OR_RETURN(auto res, _aggregator->pull_eos_chunk());
     DCHECK(_accumulator.need_input());
-    _accumulator.push(std::move(res));
+    if (res && !res->is_empty()) {
+        _accumulator.push(std::move(res));
+    }
     _accumulator.finalize();
-    auto accumulated = std::move(_accumulator.pull());
-    _aggregator->offer_chunk_to_buffer(accumulated);
+    if (_accumulator.has_output()) {
+        auto accumulated = std::move(_accumulator.pull());
+        _aggregator->offer_chunk_to_buffer(accumulated);
+    }
+
     _aggregator->set_ht_eos();
     _aggregator->sink_complete();
     return Status::OK();