[BugFix] Prevent crash if type mismatch in BinaryDictPageDecoder (bac…

…kport #52036) (#52065) Co-authored-by: Binglin Chang <[email protected]>
StarRocks · Oct 17, 2024 · 04ee523 · 04ee523
1 parent ee7dc9d
commit 04ee523
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/be/src/storage/rowset/binary_dict_page.cpp b/be/src/storage/rowset/binary_dict_page.cpp
@@ -260,7 +260,9 @@ Status BinaryDictPageDecoder<Type>::next_batch(const SparseRange& range, Column*
         }
     }
 
-    CHECK(dst->append_strings_overflow(slices, _max_value_legth));
+    bool ok = dst->append_strings_overflow(slices, _max_value_legth);
+    DCHECK(ok) << "append_strings_overflow failed";
+    RETURN_IF(!ok, Status::InternalError("BinaryDictPageDecoder::next_batch failed"));
     return Status::OK();
 }