Rebasing changes into feature branch #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Do not leak comment tags to HTML * feat: Clean up z-index hacks There were a lot of unnessecary z-index rules, cleaning up the DOM should avoid them * feat: avoid using z-index at all Since z-index can collide with other elements outside of the embed * feat: init styles clean up There should be an init style before consent styles are loaded * feat: Use data attribute instead of class in HTML Putting services as class names might run into conflict with other styles on a wiki For example, the wiki might have another element with the class name youtube This should help mitigate it * feat: add Spotify oembed integration * docs: Add notes on Bilibili and Niconico API * refactor: Update oembed calls Add an optional config dict for accessing info endpoint data Soundcloud Oembed seems fine, tested with https://soundcloud.com/oembed?format=json&url=https://soundcloud.com/turbokevin/turbokevin-chase-the-sun Co-authored-by: Hannes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.