Modest updates to Readme.md #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A humble bare-bones attempt at adding a service capable of serving embeds like this one - https://media.dlib.indiana.edu/media_objects/pg15bg11k It barely works
add example, rename examples youtube examples, will add service specific examples later
|
note 4 commits - this PR should no longer be named "Very M" (apologies for my clumsiness) |
|
Thank you very much for your contribution! One general note: Could you split the readme changes and addition of a service into two separate pull request? |
|
Will do
…On Sun, Oct 31, 2021, 10:35 AM H. C. Kruse ***@***.***> wrote:
Thank you very much for your contribution!
One general note: Could you split the readme changes and addition of a
service into two separate pull request?
This way everything is clean and separated
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAU2VNIJA4HGQ6SEIIL7R2LUJVHZTANCNFSM5HBFYKDA>
.
|
Jerimee
changed the title
|
ok this is now just README and small typo |
|
Merged. Thanks again for the readme updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is a baby step; it does only two things: correct a minor spelling typo in english and update readme.md
It is a branch based on develop NOT MASTER branch