Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be less restrictive about the chosen swiftlint version #28

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Aug 28, 2024

Be less restrictive about the chosen swiftlint version

♻️ Current situation & Problem

This PR loosens the restrictions on the swiftlint version.

⚙️ Release Notes

  • Allow upToNextMajor swiftlint versions.
  • Some additional concurrency fixes.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer August 28, 2024 13:18
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this; seems like some of the builds are no longer passing; let me know if you need help to investigate this 👍

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (853585f) to head (71c0429).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files           1        1           
  Lines          45       45           
=======================================
  Hits           38       38           
  Misses          7        7           
Files with missing lines Coverage Δ
Sources/SpeziQuestionnaire/QuestionnaireView.swift 84.45% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 853585f...71c0429. Read the comment docs.

@Supereg Supereg merged commit d0bd55f into main Aug 29, 2024
8 checks passed
@Supereg Supereg deleted the fix/swiftlint-version branch August 29, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants