Pull Request

SpeziViews #621

Sign in to view logs

GitHub Actions / detekt failed Nov 10, 2024 in 1s

reviewdog [detekt] report

reported by reviewdog 🐶

Findings (38)

core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt|7 col 3| The class or object DefaultValidationRulesSimulator is empty.
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt|8 col 1| Unexpected blank line(s) before "}"
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt|7 col 3| Unnecessary block ("{}")
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt|5 col 7| The class DefaultValidationRulesSimulator defines no functionality and only holds data. Consider converting it to a data class.
core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt|33 col 1| Unexpected blank line(s) before "}"
core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt|7 col 1| Unused import
core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt|7 col 1| The import 'kotlinx.coroutines.CoroutineScope' is unused.
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/composables/FocusValidationRules.kt|11 col 1| Unused import
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/composables/FocusValidationRules.kt|11 col 1| The import 'androidx.compose.runtime.rememberCoroutineScope' is unused.
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt|3 col 1| Unused import
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt|5 col 1| Unused import
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt|8 col 1| Unused import
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt|9 col 1| Unused import
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt|43 col 1| Unexpected blank line(s) before "}"
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt|3 col 1| The import 'androidx.compose.runtime.mutableStateOf' is unused.
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt|5 col 1| The import 'androidx.compose.ui.test.onNodeWithText' is unused.
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt|8 col 1| The import 'edu.stanford.spezi.core.design.views.validation.state.ValidationContext' is unused.
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt|9 col 1| The import 'kotlinx.coroutines.delay' is unused.
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt|3 col 1| Unused import
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt|5 col 1| Unused import
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt|3 col 1| The import 'androidx.compose.material3.Text' is unused.
core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt|5 col 1| The import 'androidx.compose.ui.test.assertIsOn' is unused.
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/views/viewModifier/viewState/OperationStateAlert.kt|11 col 31| Missing trailing comma before ")"
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/views/views/button/SuspendButton.kt|24 col 34| Missing trailing comma before ")"
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/personalInfo/UserProfileComposable.kt|3 col 1| Unused import
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/personalInfo/UserProfileComposable.kt|18 col 1| Unused import
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/personalInfo/UserProfileComposable.kt|3 col 1| The import 'androidx.compose.foundation.Image' is unused.
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/personalInfo/UserProfileComposable.kt|18 col 1| The import 'androidx.compose.ui.graphics.vector.ImageVector' is unused.
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/state/CapturedValidationStateEntries.kt|8 col 81| Missing trailing comma before ")"
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/state/CapturedValidationStateEntries.kt|8 col 5| Constructor private parameter names should match the pattern: [a-z][A-Za-z0-9]*
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/state/ValidationContext.kt|4 col 69| Missing trailing comma before ")"
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/state/FailedValidationResult.kt|9 col 32| Missing trailing comma before ")"
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/ValidationResultsComposable.kt|1 col 1| File must end with a newline (\n)
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/ValidationResultsComposable.kt|13 col 42| Missing trailing comma before ")"
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/ValidationResultsComposable.kt|26 col 2| The file /github/workspace/core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/ValidationResultsComposable.kt is not ending with a new line.
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/VerifiableTextField.kt|28 col 40| Missing trailing comma before ")"
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/views/VerifiableTextField.kt|45 col 40| Missing trailing comma before ")"
core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/validation/ValidationRule.kt|12 col 79| Missing trailing comma before ")"

Filtered Findings (0)

Annotations

Check warning on line 7 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt#L7 <detekt.EmptyClassBlock>

The class or object DefaultValidationRulesSimulator is empty.

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt:7:3: warning: The class or object DefaultValidationRulesSimulator is empty. (detekt.EmptyClassBlock)

Check warning on line 8 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt#L8 <detekt.NoBlankLineBeforeRbrace>

Unexpected blank line(s) before "}"

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt:8:1: warning: Unexpected blank line(s) before "}" (detekt.NoBlankLineBeforeRbrace)

Check warning on line 7 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt#L7 <detekt.NoEmptyClassBody>

Unnecessary block ("{}")

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt:7:3: warning: Unnecessary block ("{}") (detekt.NoEmptyClassBody)

Check warning on line 5 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt#L5 <detekt.UseDataClass>

The class DefaultValidationRulesSimulator defines no functionality and only holds data. Consider converting it to a data class.

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/DefaultValidationRulesSimulator.kt:5:7: warning: The class DefaultValidationRulesSimulator defines no functionality and only holds data. Consider converting it to a data class. (detekt.UseDataClass)

Check warning on line 33 in core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt

github-actions / detekt

[detekt] core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt#L33 <detekt.NoBlankLineBeforeRbrace>

Unexpected blank line(s) before "}"

Raw output


            /github/workspace/core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt:33:1: warning: Unexpected blank line(s) before "}" (detekt.NoBlankLineBeforeRbrace)

Check warning on line 7 in core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt

github-actions / detekt

[detekt] core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt#L7 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt:7:1: warning: Unused import (detekt.NoUnusedImports)

Check warning on line 7 in core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt

github-actions / detekt

[detekt] core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt#L7 <detekt.UnusedImports>

The import 'kotlinx.coroutines.CoroutineScope' is unused.

Raw output


            /github/workspace/core/design/src/test/kotlin/edu/stanford/spezi/core/design/SpeziValidationTest.kt:7:1: warning: The import 'kotlinx.coroutines.CoroutineScope' is unused. (detekt.UnusedImports)

Check warning on line 11 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/composables/FocusValidationRules.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/composables/FocusValidationRules.kt#L11 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/composables/FocusValidationRules.kt:11:1: warning: Unused import (detekt.NoUnusedImports)

Check warning on line 11 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/composables/FocusValidationRules.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/composables/FocusValidationRules.kt#L11 <detekt.UnusedImports>

The import 'androidx.compose.runtime.rememberCoroutineScope' is unused.

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/composables/FocusValidationRules.kt:11:1: warning: The import 'androidx.compose.runtime.rememberCoroutineScope' is unused. (detekt.UnusedImports)

Check warning on line 3 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt#L3 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt:3:1: warning: Unused import (detekt.NoUnusedImports)

Check warning on line 5 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt#L5 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt:5:1: warning: Unused import (detekt.NoUnusedImports)

Check warning on line 8 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt#L8 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt:8:1: warning: Unused import (detekt.NoUnusedImports)

Check warning on line 9 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt#L9 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt:9:1: warning: Unused import (detekt.NoUnusedImports)

Check warning on line 43 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt#L43 <detekt.NoBlankLineBeforeRbrace>

Unexpected blank line(s) before "}"

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt:43:1: warning: Unexpected blank line(s) before "}" (detekt.NoBlankLineBeforeRbrace)

Check warning on line 3 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt#L3 <detekt.UnusedImports>

The import 'androidx.compose.runtime.mutableStateOf' is unused.

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt:3:1: warning: The import 'androidx.compose.runtime.mutableStateOf' is unused. (detekt.UnusedImports)

Check warning on line 5 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt#L5 <detekt.UnusedImports>

The import 'androidx.compose.ui.test.onNodeWithText' is unused.

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt:5:1: warning: The import 'androidx.compose.ui.test.onNodeWithText' is unused. (detekt.UnusedImports)

Check warning on line 8 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt#L8 <detekt.UnusedImports>

The import 'edu.stanford.spezi.core.design.views.validation.state.ValidationContext' is unused.

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt:8:1: warning: The import 'edu.stanford.spezi.core.design.views.validation.state.ValidationContext' is unused. (detekt.UnusedImports)

Check warning on line 9 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt#L9 <detekt.UnusedImports>

The import 'kotlinx.coroutines.delay' is unused.

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/ValidationTest.kt:9:1: warning: The import 'kotlinx.coroutines.delay' is unused. (detekt.UnusedImports)

Check warning on line 3 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt#L3 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt:3:1: warning: Unused import (detekt.NoUnusedImports)

Check warning on line 5 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt#L5 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt:5:1: warning: Unused import (detekt.NoUnusedImports)

Check warning on line 3 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt#L3 <detekt.UnusedImports>

The import 'androidx.compose.material3.Text' is unused.

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt:3:1: warning: The import 'androidx.compose.material3.Text' is unused. (detekt.UnusedImports)

Check warning on line 5 in core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt

github-actions / detekt

[detekt] core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt#L5 <detekt.UnusedImports>

The import 'androidx.compose.ui.test.assertIsOn' is unused.

Raw output


            /github/workspace/core/design/src/androidTest/kotlin/edu/stanford/spezi/core/design/simulator/FocusValidationRulesSimulator.kt:5:1: warning: The import 'androidx.compose.ui.test.assertIsOn' is unused. (detekt.UnusedImports)

Check warning on line 11 in core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/views/viewModifier/viewState/OperationStateAlert.kt

github-actions / detekt

[detekt] core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/views/viewModifier/viewState/OperationStateAlert.kt#L11 <detekt.TrailingCommaOnDeclarationSite>

Missing trailing comma before ")"

Raw output


            /github/workspace/core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/views/viewModifier/viewState/OperationStateAlert.kt:11:31: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)

Check warning on line 24 in core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/views/views/button/SuspendButton.kt

github-actions / detekt

[detekt] core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/views/views/button/SuspendButton.kt#L24 <detekt.TrailingCommaOnDeclarationSite>

Missing trailing comma before ")"

Raw output


            /github/workspace/core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/views/views/button/SuspendButton.kt:24:34: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)

Check warning on line 3 in core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/personalInfo/UserProfileComposable.kt

github-actions / detekt

[detekt] core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/personalInfo/UserProfileComposable.kt#L3 <detekt.NoUnusedImports>

Unused import

Raw output


            /github/workspace/core/design/src/main/kotlin/edu/stanford/spezi/core/design/views/personalInfo/UserProfileComposable.kt:3:1: warning: Unused import (detekt.NoUnusedImports)

View more details on GitHub Actions