-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 42 local storage encryption #47
Conversation
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
=========================================
Coverage 27.54% 27.54%
Complexity 228 228
=========================================
Files 105 105
Lines 3102 3102
Branches 439 439
=========================================
Hits 854 854
Misses 2196 2196
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Basler182 for working on this; this will be helpful for ENGAGE-HF and a lot of future projects!
# Conflicts: # gradle/libs.versions.toml # settings.gradle.kts
...droidTest/kotlin/edu/stanford/spezi/modules/storage/file/EncryptedFileKeyValueStorageTest.kt
Outdated
Show resolved
Hide resolved
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/file/EncryptedFileStorage.kt
Show resolved
Hide resolved
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/file/EncryptedFileStorage.kt
Show resolved
Hide resolved
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/key/LocalKeyValueStorage.kt
Outdated
Show resolved
Hide resolved
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/key/LocalKeyValueStorage.kt
Outdated
Show resolved
Hide resolved
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/key/KeyValueStorage.kt
Show resolved
Hide resolved
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Are you planning to adapt factory approach with support for multiple storage files as part of this PR?
Feature/issue 42 local storage encryption
♻️ Current situation & Problem
#42
⚙️ Release Notes
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: