fix #59 removed video description nullability

app/src/main/kotlin/edu/stanford/bdh/engagehf/education/VideoSectionDocumentToVideoSectionMapper.kt

@@ -41,11 +41,12 @@ class VideoSectionDocumentToVideoSectionMapper @Inject constructor(
         val jsonMap = document.data
 
         val videoTitle = localizedMapReader.get(key = "title", jsonMap = jsonMap)
+        val videoDescription = localizedMapReader.get(key = "description", jsonMap = jsonMap)
         val youtubeId = document.get("youtubeId") as? String
-        return if (videoTitle != null && youtubeId != null) {
+        return if (videoTitle != null && youtubeId != null && videoDescription != null) {
             Video(
                 title = videoTitle,
-                description = localizedMapReader.get(key = "description", jsonMap = jsonMap),
+                description = videoDescription,
                 orderIndex = document.get("orderIndex") as? Int ?: 0,
                 youtubeId = youtubeId
             )

app/src/test/kotlin/edu/stanford/bdh/engagehf/education/VideoSectionDocumentToVideoSectionMapperTest.kt

@@ -15,7 +15,7 @@ class VideoSectionDocumentToVideoSectionMapperTest {
     private val mapper = VideoSectionDocumentToVideoSectionMapper(localizedMapReader)
 
     @Test
-    fun `it should return null if title or description is missing`() = runTest {
+    fun `it should return null if title and description is missing`() = runTest {
         // given
         val document: DocumentSnapshot = mockk()
         every { document.data } returns null
@@ -29,6 +29,21 @@ class VideoSectionDocumentToVideoSectionMapperTest {
         assertThat(result).isNull()
     }
 
+    @Test
+    fun `it should return null if description is missing`() = runTest {
+        // given
+        val document: DocumentSnapshot = mockk()
+        every { document.data } returns null
+        every { localizedMapReader.get("title", null) } returns "title"
+        every { localizedMapReader.get("description", null) } returns null
+
+        // when
+        val result = mapper.map(document)
+
+        // then
+        assertThat(result).isNull()
+    }
+
     @Test
     fun `it should return null if no videos found`() = runTest {
         // given
@@ -101,7 +116,12 @@ class VideoSectionDocumentToVideoSectionMapperTest {
             }
         }
         every { localizedMapReader.get("title", videoSectionJsonMap) } returns "Test Title"
-        every { localizedMapReader.get("description", videoSectionJsonMap) } returns "Test Description"
+        every {
+            localizedMapReader.get(
+                "description",
+                videoSectionJsonMap
+            )
+        } returns "Test Description"
 
         // when
         val result = requireNotNull(mapper.map(document))

modules/education/src/main/java/edu/stanford/spezi/modules/education/video/VideoScreen.kt

@@ -71,15 +71,13 @@ fun VideoScreen(
                         .testIdentifier(VideoScreenTestIdentifier.VIDEO_PLAYER)
                 )
 
-                video.description?.let {
-                    Text(
-                        text = it,
-                        style = TextStyles.bodyMedium,
-                        modifier = Modifier
-                            .padding(Spacings.medium)
-                            .testIdentifier(VideoScreenTestIdentifier.VIDEO_DESCRIPTION)
-                    )
-                }
+                Text(
+                    text = video.description,
+                    style = TextStyles.bodyMedium,
+                    modifier = Modifier
+                        .padding(Spacings.medium)
+                        .testIdentifier(VideoScreenTestIdentifier.VIDEO_DESCRIPTION)
+                )
             }
         }
     )

modules/education/src/main/java/edu/stanford/spezi/modules/education/videos/EducationUiState.kt

@@ -24,7 +24,7 @@ data class VideoSection(
 @Serializable
 data class Video(
     val title: String,
-    val description: String? = null,
+    val description: String,
     val orderIndex: Int = 0,
     val youtubeId: String,
 ) {

modules/education/src/test/java/edu/stanford/spezi/modules/education/education/videos/EducationViewModelTest.kt

@@ -55,6 +55,7 @@ class EducationViewModelTest {
                     Video(
                         youtubeId = youtubeId,
                         title = title,
+                        description = "description",
                     )
                 )
             )
@@ -65,7 +66,8 @@ class EducationViewModelTest {
             Action.VideoSectionClicked(
                 video = Video(
                     youtubeId = youtubeId,
-                    title = title
+                    title = title,
+                    description = "description",
                 )
             )
         )
@@ -76,7 +78,8 @@ class EducationViewModelTest {
                 EducationNavigationEvent.VideoSectionClicked(
                     video = Video(
                         youtubeId = youtubeId,
-                        title = title
+                        title = title,
+                        description = "description",
                     )
                 )
             )