Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for symptoms extraction and visualization #82

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

Vicbi
Copy link
Collaborator

@Vicbi Vicbi commented Dec 7, 2024

Enhancements for symptoms extraction and visualization

⚙️ Release Notes

  • Implemented the fetch_symptoms_single() function to output the recorded symptoms for every ECG recording or "No symptoms." when applicable.
  • Adjusted the ECGDataViewer to display symptoms data on the ECGReviewer.ipynb dashboard.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (10c070f) to head (82d5296).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   81.34%   82.62%   +1.28%     
==========================================
  Files          34       34              
  Lines        1254     1254              
==========================================
+ Hits         1020     1036      +16     
+ Misses        234      218      -16     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c070f...82d5296. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Vicbi; looks great, thank you for all the work!

Feel free to merge the PR once @aydinzahedi or Scott had a chance to review the changes and provided feedback 🚀

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Dec 8, 2024
@Vicbi Vicbi force-pushed the addSymptomsInViewer branch 6 times, most recently from 47f694c to 9b3ee83 Compare December 8, 2024 21:59
@Vicbi Vicbi force-pushed the addSymptomsInViewer branch from 9b3ee83 to 82d5296 Compare December 8, 2024 22:02
@Vicbi Vicbi merged commit d66e09d into main Dec 10, 2024
13 of 14 checks passed
@Vicbi Vicbi deleted the addSymptomsInViewer branch December 10, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants