Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring to enable transitin to Colab Enterprise #70

Merged
merged 27 commits into from
Jul 17, 2024

Conversation

Vicbi
Copy link
Collaborator

@Vicbi Vicbi commented Jul 17, 2024

Minor refactoring to enable transition to Colab Enterprise

⚙️ Release Notes

  • Renamed ELECTROCARDIOGRAM_CLASSIFICATION to APPLE_ELECTROCARDIOGRAM_CLASSIFICATION
  • Updated Python notebooks for Colab Enterprise integration.
  • Updated README.md.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Vicbi Vicbi requested a review from PSchmiedmayer July 17, 2024 05:46
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (8fa93b6) to head (851dd07).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files          39       39           
  Lines        1417     1417           
=======================================
  Hits         1055     1055           
  Misses        362      362           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa93b6...851dd07. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements @Vicbi; great to see the final steps coming into play!

ecg_data_manager/requirements.txt Show resolved Hide resolved
@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Jul 17, 2024
@Vicbi Vicbi merged commit eae1fce into main Jul 17, 2024
14 checks passed
@Vicbi Vicbi deleted the transition_to_colab_enterprise branch July 17, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants