Upload Indicator #59
Merged
Upload Indicator #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 58.60% 58.05% -0.54%
==========================================
Files 39 39
Lines 1379 1392 +13
==========================================
Hits 808 808
- Misses 571 584 +13
Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Thank you @MatthewTurk247; I updated a few smaller elements and will merge the PR.
MatthewTurk247
added a commit
that referenced
this pull request
May 17, 2024
# ECG Data Management ## ♻️ Current situation & Problem Some ECGs are not showing up in the app as expected, and it is not entirely clear when and why the issue occurs. One possible solution is that every time the application boots up, it loops through all samples and checks if they have been uploaded. ## ⚙️ Release Notes - Adds local notifications for testing and surfacing error messages. - Uses Firebase Authentication instead of Spezi Account where appropriate. - Adds pull to refresh in ECG list view, allowing for manual triggers to reload data from HealthKit. - Fetches upload status from Firebase rather than local. - Moves upload logic from `PAWSStandard` to `ECGModule`. ## 📚 Documentation See #59. ## ✅ Testing TBD. ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md). --------- Co-authored-by: Paul Schmiedmayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload Indicator
♻️ Current situation & Problem
Some of the ECG uploads are a little flaky. Even when the app shows that new samples have been read, not all of them are making it to Firebase as one would expect. The first step in solving this problem is identifying which samples are not making it to Firebase.
⚙️ Release Notes
✅ Testing
Upload status comes from the
isUploadedfunction inECGModule.Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: