-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECG Data Pipeline Tool #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vicbi I have not taken a closer look at the Python code as I trust you with that and we will have to remodel this for the shared python package anyways.
I had a few suggestions about the documentation and general structure that we could incorporate.
Let's keep this PR open for a bit until we synced back with Scott and Aydin after the next meeting and the next iteration of the tool.
ECGDataPipelineTemplate/Figures/ecg_data_interactive_tool_snapshot.png
Outdated
Show resolved
Hide resolved
@Vicbi The latest commit should fix the Xcode Build issue 👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 28.17% 28.17%
=======================================
Files 34 34
Lines 1232 1232
=======================================
Hits 347 347
Misses 885 885 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of the Xcode Build issue @PSchmiedmayer ! All other changes were made 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements; I had a few comments and elements that I observed in the README and other parts of the code that would be great to address before we merge the PR.
github.com:StanfordBDHG/PediatricAppleWatchStudy into addECGDataPipeline
Add ECG Data Pipeline Tool
♻️ Current situation & Problem
This PR adds the ECG Data Pipeline tool into a separate folder in the root of the project repository. Currently, the project lacks a dedicated pipeline for processing, analyzing and visualising the ECG data. This addition aims to provide a streamlined way to handle ECG data with enhanced analysis and visualisation capabilities.
⚙️ Release Notes
📚 Documentation
The ECG Data Pipeline tool is fully documented. The README within the ECG Data Pipeline folder provides an overview, setup instructions, and usage examples for integration and utilization of the tool.
✅ Testing
A job to build and test the ECG Data Pipeline notebook was added into the existing workflow build-and-test. This includes setting up Python, NodeJS, Java, and LaTeX environments; installing necessary dependencies; and executing the notebook with Firebase emulators to validate the data pipeline's functionality. The notebook is then converted to a PDF document, which is uploaded as an artifact for review.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: