Patient Age Group #52
Conversation
There was a problem hiding this comment.
Thank you for the improvements @MatthewTurk247; I had feedback regarding the storage of the information. Apart from this the overall approach looks good to me.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 28.17% 28.44% +0.27%
==========================================
Files 34 35 +1
Lines 1232 1245 +13
==========================================
+ Hits 347 354 +7
- Misses 885 891 +6
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
@MatthewTurk247 Thank you for the updates. I have a question regarding the unit test. If we run into the code coverage issues I think we can merge it slightly below coverage as long as the core logic in e.g. a Date extension is tested.
# Switch Bios ## ♻️ Current situation & Problem Provides support for switching the list of contacts featured in the app, depending on whether the user is enrolled in the pediatric study or the adult study. Each patient is assigned an age group in Firebase when they sign up. ## ⚙️ Release Notes - Uses a Boolean variable (based on `account` environment variable) indicating whether the logged-in user is in the pediatric age group or the adult age group. - Adds new localized strings and if statements to switch between text. - Adds UI tests for said switches. ## 📚 Documentation See #52. ## ✅ Testing Included in code changes. ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md). --------- Co-authored-by: Paul Schmiedmayer <[email protected]>
Patient Age Group
♻️ Current situation & Problem
We need a way to determine whether a patient is part of the upcoming pediatric study or the upcoming adult study so that UI can be updated accordingly.
⚙️ Release Notes
✅ Testing
Because of the
guardstatement at the beginning of the function body of interest, the bulk of the meaningful testing will be manual inspections of Firebase.Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: