Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firebase Component + Account Management #5

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Conversation

PSchmiedmayer
Copy link
Member

@PSchmiedmayer PSchmiedmayer commented Feb 16, 2023

Add Firebase Component + Account Management

♻️ Current situation & Problem

The current PAWS application does not include a user login functionality and does not connect to a cloud storage provider.

💡 Proposed solution

This PR adds a Firebase-based login & account sign up mechanism and the Firestone component to automatically upload observations and other FHIR resources to Firebase.

Related PRs

Testing

  • Adapts the UI test accordingly.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer changed the title Add Firebase Compoennt + Account Management Add Firebase Compoent + Account Management Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #5 (a7bc94c) into main (565f26b) will decrease coverage by 0.28%.
The diff coverage is 82.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   82.15%   81.87%   -0.28%     
==========================================
  Files          28       34       +6     
  Lines         801     1075     +274     
==========================================
+ Hits          658      880     +222     
- Misses        143      195      +52     
Impacted Files Coverage Δ
...es/PAWSOnboardingFlow/AccountSetup/PAWSLogin.swift 0.00% <0.00%> (ø)
...WSModules/Sources/PAWSOnboardingFlow/Consent.swift 0.00% <0.00%> (ø)
...ces/PAWSOnboardingFlow/AccountSetup/IconView.swift 68.43% <68.43%> (ø)
...s/PAWSOnboardingFlow/AccountSetup/PAWSSignUp.swift 73.34% <73.34%> (ø)
...es/Sources/PAWSOnboardingFlow/OnboardingFlow.swift 85.72% <83.34%> (-0.49%) ⬇️
...dules/Sources/PAWSSharedContext/Bundle+Image.swift 83.34% <83.34%> (ø)
PAWSUITests/OnboardingTests.swift 78.11% <86.00%> (+4.54%) ⬆️
...ces/PAWSOnboardingFlow/AccountSetup/UserView.swift 88.10% <88.10%> (ø)
...PAWSOnboardingFlow/AccountSetup/AccountSetup.swift 92.40% <92.40%> (ø)
PAWS/PAWSAppDelegate.swift 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 565f26b...a7bc94c. Read the comment docs.

@PSchmiedmayer PSchmiedmayer requested a review from a team February 16, 2023 20:32
@PSchmiedmayer PSchmiedmayer changed the title Add Firebase Compoent + Account Management Add Firebase Component + Account Management Feb 16, 2023
@PSchmiedmayer
Copy link
Member Author

@CS342/2023-paws A short reminder that this PR is still open 👋

Copy link
Contributor

@ckunchur ckunchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Copy link
Contributor

@ckunchur ckunchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@ckunchur ckunchur merged commit e538c0e into main Feb 22, 2023
@ckunchur ckunchur deleted the feature/firebase branch February 22, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants