Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Notifications #33

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Fix Notifications #33

merged 1 commit into from
Mar 15, 2023

Conversation

PSchmiedmayer
Copy link
Member

Fix Notifications

♻️ Current situation & Problem

  • Notifications are not triggered on a device

💡 Proposed solution

  • Reorder the steps of asking for permissions and then scheduling a notification
  • Removes the remote notification entitlements

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #33 (e07e7b1) into main (3d7ad13) will increase coverage by 23.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #33       +/-   ##
===========================================
+ Coverage   62.43%   85.98%   +23.56%     
===========================================
  Files          43        8       -35     
  Lines        2028      271     -1757     
===========================================
- Hits         1266      233     -1033     
+ Misses        762       38      -724     

see 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7ad13...e07e7b1. Read the comment docs.

@PSchmiedmayer PSchmiedmayer requested review from riyakaru and a team March 15, 2023 05:47
@ckunchur ckunchur merged commit 9d1b390 into main Mar 15, 2023
@ckunchur ckunchur deleted the bugfix/fixNotifications branch March 15, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants