Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testflightnotif #32

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Testflightnotif #32

merged 4 commits into from
Mar 15, 2023

Conversation

riyakaru
Copy link
Contributor

Name of the PR

♻️ Current situation & Problem

Describe the current situation (if possible, with an exemplary (or real) code snippet and/or where this is used)
Please link any open issue that is addressed with this PR

💡 Proposed solution

Describe the solution and how this affects the project and internal structure

⚙️ Release Notes

Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.

➕ Additional Information

Provide some additional information if possible

Related PRs

Reference the related PRs

Testing

Are there tests included? If yes, which situations are tested, and which corner cases are missing?

Reviewer Nudging

Where should the reviewer start? Where is a good entry point?

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

riyakaru03 and others added 2 commits March 13, 2023 13:35
Co-authored-by: Riya Karumanchi <[email protected]>
Co-authored-by: Riya Karumanchi <[email protected]>
Co-authored-by: Vishnu Ravi <[email protected]>
@riyakaru riyakaru requested a review from RSamavedam March 14, 2023 06:24
@RSamavedam
Copy link
Contributor

lgtm!

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #32 (1a21bde) into main (6af0547) will not change coverage.
The diff coverage is n/a.

❗ Current head 1a21bde differs from pull request most recent head 05260bd. Consider uploading reports for the commit 05260bd to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   56.91%   56.91%           
=======================================
  Files          43       43           
  Lines        2028     2028           
=======================================
  Hits         1154     1154           
  Misses        874      874           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af0547...05260bd. Read the comment docs.

@PSchmiedmayer
Copy link
Member

@riyakaru Thank you for the PR!
It would also be great if you can change the firebase emulator settings in PAWSModules/Sources/PAWSSharedContext/FeatureFlags.swift back to the following state:

public static let useFirebaseEmulator = true

Copy link
Contributor

@RSamavedam RSamavedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@RSamavedam RSamavedam merged commit 3d7ad13 into main Mar 15, 2023
@RSamavedam RSamavedam deleted the testflightnotif branch March 15, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants