Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes #31

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Bug Fixes #31

merged 1 commit into from
Mar 13, 2023

Conversation

riyakaru
Copy link
Contributor

Name of the PR

♻️ Current situation & Problem

Describe the current situation (if possible, with an exemplary (or real) code snippet and/or where this is used)
Please link any open issue that is addressed with this PR

💡 Proposed solution

Describe the solution and how this affects the project and internal structure

⚙️ Release Notes

Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.

➕ Additional Information

Provide some additional information if possible

Related PRs

Reference the related PRs

Testing

Are there tests included? If yes, which situations are tested, and which corner cases are missing?

Reviewer Nudging

Where should the reviewer start? Where is a good entry point?

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Co-authored-by: Riya Karumanchi <[email protected]>
Co-authored-by: Riya Karumanchi <[email protected]>
Co-authored-by: Vishnu Ravi <[email protected]>
@riyakaru riyakaru requested a review from PSchmiedmayer March 13, 2023 20:39
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #31 (9162621) into main (2bec347) will increase coverage by 3.45%.
The diff coverage is 16.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   81.43%   84.88%   +3.45%     
==========================================
  Files          42        8      -34     
  Lines        1965      271    -1694     
==========================================
- Hits         1600      230    -1370     
+ Misses        365       41     -324     
Impacted Files Coverage Δ
PAWSUITests/HealthKitUploadTests.swift 0.00% <ø> (-100.00%) ⬇️
PAWSUITests/OnboardingTests.swift 83.34% <16.67%> (-11.51%) ⬇️

... and 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bec347...9162621. Read the comment docs.

@riyakaru riyakaru requested a review from abhinav30219 March 13, 2023 20:56
Copy link
Contributor

@abhinav30219 abhinav30219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed the code in codespace to check if all the bug fixes Paul highlighted were made. Everything looks good and TestFlight deployment should be successful now.

@abhinav30219 abhinav30219 merged commit 6af0547 into main Mar 13, 2023
@abhinav30219 abhinav30219 deleted the bugfixes branch March 13, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants