Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies to fix the ECG Data Upload #23

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

PSchmiedmayer
Copy link
Member

@PSchmiedmayer PSchmiedmayer commented Mar 7, 2023

Update Dependencies to fix the ECG Data Upload

♻️ Current situation & Problem

  • The current electrocardiogram mapping does not automatically collect symptoms and raw voltage data as expected.

💡 Proposed solution

Results in the fully defined fields in the Firebase Emulator:
Screenshot 2023-03-07 at 3 40 37 PM

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #23 (871c19e) into main (267840c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files           8        8           
  Lines         287      287           
=======================================
  Hits          279      279           
  Misses          8        8           
Impacted Files Coverage Δ
PAWS/PAWSAppDelegate.swift 97.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267840c...871c19e. Read the comment docs.

@PSchmiedmayer PSchmiedmayer requested a review from a team March 8, 2023 00:25
Copy link
Contributor

@ananya-vasireddy ananya-vasireddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@ananya-vasireddy ananya-vasireddy merged commit 92d2811 into main Mar 8, 2023
@ananya-vasireddy ananya-vasireddy deleted the bugfix/fixECGUpload branch March 8, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants