Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made functional and UI updates to homescreen #21

Merged
merged 5 commits into from
Mar 3, 2023
Merged

Made functional and UI updates to homescreen #21

merged 5 commits into from
Mar 3, 2023

Conversation

abhinav30219
Copy link
Contributor

Homescreen updated version

♻️ Current situation & Problem

Describe the current situation (if possible, with an exemplary (or real) code snippet and/or where this is used)
Please link any open issue that is addressed with this PR

💡 Proposed solution

Describe the solution and how this affects the project and internal structure

⚙️ Release Notes

Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.

➕ Additional Information

Provide some additional information if possible

Related PRs

Reference the related PRs

Testing

Are there tests included? If yes, which situations are tested, and which corner cases are missing?

Reviewer Nudging

Where should the reviewer start? Where is a good entry point?

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #21 (2f0046e) into main (8e28586) will decrease coverage by 27.23%.
The diff coverage is 42.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #21       +/-   ##
===========================================
- Coverage   97.22%   69.98%   -27.23%     
===========================================
  Files           8       42       +34     
  Lines         287     1865     +1578     
===========================================
+ Hits          279     1305     +1026     
- Misses          8      560      +552     
Impacted Files Coverage Δ
PAWS/PAWS.swift 100.00% <ø> (ø)
...les/Sources/PAWSMockDataStorageProvider/Home.swift 87.50% <ø> (ø)
.../PAWSMockDataStorageProvider/LatestRecording.swift 0.00% <0.00%> (ø)
...es/PAWSMockDataStorageProvider/RecordingsNav.swift 0.00% <0.00%> (ø)
...ces/PAWSOnboardingFlow/AccountSetup/UserView.swift 88.10% <ø> (ø)
...urces/PAWSMockDataStorageProvider/HomeScreen.swift 80.49% <80.49%> (ø)
...urces/PAWSMockDataStorageProvider/AboutStudy.swift 93.48% <94.45%> (ø)
...es/PAWSMockDataStorageProvider/AboutStudyNav.swift 84.00% <100.00%> (ø)
...kDataStorageProvider/MockDataStorageProvider.swift 17.95% <100.00%> (ø)
...es/PAWSNotificationScreen/NotificationScreen.swift 0.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e28586...2f0046e. Read the comment docs.

Copy link
Contributor

@ckunchur ckunchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! UI looks great and everything is functional!

@ckunchur ckunchur merged commit a2f93f1 into main Mar 3, 2023
@ckunchur ckunchur deleted the abhinav branch March 3, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants