Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed heart rate data, app should just call ECG #20

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

reddyrose
Copy link
Contributor

Name of the PR

♻️ Current situation & Problem

Describe the current situation (if possible, with an exemplary (or real) code snippet and/or where this is used)
Please link any open issue that is addressed with this PR

💡 Proposed solution

Describe the solution and how this affects the project and internal structure

⚙️ Release Notes

Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.

➕ Additional Information

Provide some additional information if possible

Related PRs

Reference the related PRs

Testing

Are there tests included? If yes, which situations are tested, and which corner cases are missing?

Reviewer Nudging

Where should the reviewer start? Where is a good entry point?

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@reddyrose reddyrose requested a review from PSchmiedmayer March 3, 2023 02:29
@reddyrose reddyrose self-assigned this Mar 3, 2023
@ckunchur ckunchur self-requested a review March 3, 2023 02:34
@ckunchur ckunchur enabled auto-merge (squash) March 3, 2023 02:34
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #20 (a6682e0) into main (5869891) will increase coverage by 27.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #20       +/-   ##
===========================================
+ Coverage   70.11%   97.22%   +27.11%     
===========================================
  Files          41        8       -33     
  Lines        1395      287     -1108     
===========================================
- Hits          978      279      -699     
+ Misses        417        8      -409     
Impacted Files Coverage Δ
PAWS/PAWSAppDelegate.swift 97.73% <ø> (-0.48%) ⬇️
...urces/PAWSMockDataStorageProvider/MockUpload.swift
...Modules/Sources/PAWSHomeScreen/RecordingsNav.swift
...AWSMockDataStorageProvider/Bundle+ECGTracing.swift
...dules/Sources/PAWSSharedContext/Bundle+Image.swift
...MockDataStorageProvider/MockUploadDetailView.swift
...ockDataStorageProvider/MockUploadList-filter.swift
...Sources/PAWSMockDataStorageProvider/LazyText.swift
...WSModules/Sources/PAWSOnboardingFlow/Consent.swift
...ces/PAWSOnboardingFlow/AccountSetup/UserView.swift
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5869891...a6682e0. Read the comment docs.

Copy link
Contributor

@ckunchur ckunchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra data successfully removed!

@ckunchur ckunchur merged commit 105189c into main Mar 3, 2023
@ckunchur ckunchur deleted the shriya branch March 3, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants