Feature/reports #12
Merged
Feature/reports #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 90.12% 89.45% -0.67%
==========================================
Files 9 9
Lines 344 322 -22
==========================================
- Hits 310 288 -22
Misses 34 34
Continue to review full report at Codecov.
|
ananya-vasireddy
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check Upload Status
♻️ Current situation & Problem
Describe the current situation (if possible, with an exemplary (or real) code snippet and/or where this is used)
Please link any open issue that is addressed with this PR
Previously, the status upload feature was only slightly modified from the MockUpload view and did not conform to our design standards.
💡 Proposed solution
Describe the solution and how this affects the project and internal structure
The MockUpload header was modified to extract the date and time more cleanly and modify view color based on upload status.
⚙️ Release Notes
Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.
➕ Additional Information
Provide some additional information if possible
Removed old notifications tab (just have "Reports" aka old MockUpload tab now).
Related PRs
Reference the related PRs
See #3 for status update logic.
Testing
Are there tests included? If yes, which situations are tested, and which corner cases are missing?
Reviewer Nudging
Where should the reviewer start? Where is a good entry point?
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: