Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TS built-in types #24

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

arkadiuszbachorski
Copy link
Contributor

Make TS stricter

♻️ Current situation & Problem

TypeScript types for standard lib have couple decisions that could be better. One of them is any return type from JSON.parse and res.json().

⚙️ Release Notes

  • Improve TS built-in types

📚 Documentation

reset.d.ts fixes them all making TS code more safe and more pleasant to work with. See rules for all the changes.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5ce0539) to head (c125002).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            6         6           
  Branches         1         1           
=========================================
  Hits             6         6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2bb4e7...c125002. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; checked out their web page, wasn't aware of this and it looks useful!
Thanks for improving all of the setup here step-by-step @arkadiuszbachorski!

@arkadiuszbachorski arkadiuszbachorski merged commit 3110680 into main Jun 4, 2024
10 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/make-ts-stricter branch June 4, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants