Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecosystem Upgrades and Reusability Improvements #61

Merged
merged 13 commits into from
Nov 10, 2024

Minor test adjusments

fb9995a
Select commit
Loading
Failed to load commit list.
Merged

Ecosystem Upgrades and Reusability Improvements #61

Minor test adjusments
fb9995a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 10, 2024 in 0s

80.29% (-0.83%) compared to 52fcfc9

View this Pull Request on Codecov

80.29% (-0.83%) compared to 52fcfc9

Details

Codecov Report

Attention: Patch coverage is 86.25954% with 36 lines in your changes missing coverage. Please review.

Project coverage is 80.29%. Comparing base (52fcfc9) to head (fb9995a).

Files with missing lines Patch % Lines
.../Biopot/Characteristics/ImpedanceMeasurement.swift 0.00% 8 Missing ⚠️
NAMS/Account/AccountSheet.swift 50.00% 6 Missing ⚠️
NAMS/Devices/Biopot/BiopotDevice.swift 50.00% 4 Missing ⚠️
NAMS/Devices/Biopot/BiopotService.swift 20.00% 4 Missing ⚠️
NAMS/Devices/Biopot/Views/BiopotDeviceRow.swift 60.00% 4 Missing ⚠️
NAMS/Devices/Mock/Views/MockDeviceRow.swift 60.00% 4 Missing ⚠️
NAMS/Devices/EmptyScanningState.swift 57.15% 3 Missing ⚠️
NAMS/NAMSAppDelegate.swift 87.50% 2 Missing ⚠️
NAMS/Devices/NearbyDevicesView.swift 66.67% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   81.12%   80.29%   -0.83%     
==========================================
  Files         112      105       -7     
  Lines        4845     4600     -245     
==========================================
- Hits         3930     3693     -237     
+ Misses        915      907       -8     
Files with missing lines Coverage Δ
NAMS/Account/AccountSetupHeader.swift 100.00% <ø> (ø)
NAMS/Account/InvestigatorCodeKey.swift 100.00% <100.00%> (+15.00%) ⬆️
...s/Biopot/Characteristics/AccelerometerSample.swift 85.72% <100.00%> (ø)
.../Devices/Biopot/Characteristics/BiopotSample.swift 88.24% <100.00%> (ø)
...vices/Biopot/Characteristics/DataAcquisition.swift 81.16% <100.00%> (ø)
...S/Devices/Biopot/Characteristics/DataControl.swift 90.91% <100.00%> (ø)
...s/Biopot/Characteristics/DeviceConfiguration.swift 95.39% <100.00%> (ø)
...ces/Biopot/Characteristics/DeviceInformation.swift 95.00% <100.00%> (ø)
...Biopot/Characteristics/SamplingConfiguration.swift 97.69% <100.00%> (ø)
...Devices/Biopot/Views/BiopotDeviceDetailsView.swift 86.16% <ø> (-1.53%) ⬇️
... and 33 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52fcfc9...fb9995a. Read the comment docs.