Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate EEG file storage using EDF/BDF files #57

Merged
merged 34 commits into from
Apr 18, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Mar 7, 2024

Integrate EEG file storage using EDF/BDF files

♻️ Current situation & Problem

This PR adds BDF file-based uploads for eeg recordings and visually updates the current recording screen.
Parts of the app have been adapted to collect additional metadata information useful to embed into EDF files.

⚙️ Release Notes

  • Add BDF file uploads for EEG recordings.
  • Refresh EEG Recording view, optimizing performance, visuals and enforcing a fixed recording timeout. This adds extended controls for chart layout (e.g., interval for x- and y-axis)
  • Add more controls for the Biopot to set electrode location assignments and hardware sample rate.
  • Collect additional patient information like date of birth and sex and a hospital administered code
  • Collection additional care provider information, like a mandatory, hospital administered code.
  • EEG devices deliver samples now using an AsyncStream resulting in way less coupling between components and overall less code.

📚 Documentation

Inline documentation were added.

✅ Testing

UI tests were updated and adjusted to cover new vectors.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg marked this pull request as ready for review April 17, 2024 03:16
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 77.21854% with 516 lines in your changes are missing coverage. Please review.

Project coverage is 81.06%. Comparing base (cbab628) to head (bc6bb0e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   84.36%   81.06%   -3.30%     
==========================================
  Files          94      112      +18     
  Lines        3330     4845    +1515     
==========================================
+ Hits         2809     3927    +1118     
- Misses        521      918     +397     
Files Coverage Δ
...s/Biopot/Characteristics/AccelerometerSample.swift 85.72% <100.00%> (ø)
...S/Devices/Biopot/Characteristics/DataControl.swift 90.91% <100.00%> (-2.84%) ⬇️
...s/Biopot/Characteristics/DeviceConfiguration.swift 95.39% <100.00%> (+1.27%) ⬆️
...ces/Biopot/Characteristics/DeviceInformation.swift 95.00% <100.00%> (+0.27%) ⬆️
...Biopot/Characteristics/SamplingConfiguration.swift 97.69% <100.00%> (+17.39%) ⬆️
NAMS/Devices/Biopot/Views/BiopotDeviceRow.swift 100.00% <100.00%> (ø)
NAMS/Devices/ConnectedDeviceDestination.swift 100.00% <100.00%> (ø)
NAMS/Devices/Mock/MockDeviceManager.swift 75.00% <ø> (ø)
NAMS/Devices/Mock/Views/MockDeviceRow.swift 100.00% <100.00%> (ø)
...s/Muse/Views/Details/MuseAboutDetailsSection.swift 100.00% <ø> (ø)
... and 65 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbab628...bc6bb0e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant