Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spezi 0.8.0 #42

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Upgrade to Spezi 0.8.0 #42

merged 3 commits into from
Nov 17, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 16, 2023

Upgrade to Spezi 0.8.0

♻️ Current situation & Problem

This PR upgrades the app to Spezi 0.8.0.

Further, we migrate the app to use the new observation framework.

⚙️ Release Notes

  • Upgrade to Spezi 0.8.0
  • Migrate to observation
  • Consistently use #Preview

📚 Documentation

--

✅ Testing

Tests were addresses as required.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg marked this pull request as ready for review November 16, 2023 06:47
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #42 (bcc4b92) into main (e84b2a5) will decrease coverage by 0.01%.
The diff coverage is 93.94%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   85.74%   85.72%   -0.01%     
==========================================
  Files          68       67       -1     
  Lines        2474     2457      -17     
==========================================
- Hits         2121     2106      -15     
+ Misses        353      351       -2     
Files Coverage Δ
NAMS/Account/AccountSetupHeader.swift 100.00% <ø> (ø)
NAMS/Account/AccountSheet.swift 95.00% <ø> (ø)
NAMS/Bluetooth/BluetoothManager.swift 100.00% <ø> (ø)
NAMS/Contacts/Contacts.swift 91.49% <ø> (ø)
NAMS/EEG/EEGChannelMark.swift 100.00% <ø> (ø)
NAMS/EEG/EEGChart.swift 96.50% <ø> (ø)
NAMS/EEG/EEGDeviceDetails.swift 77.59% <ø> (ø)
NAMS/EEG/EEGDeviceList.swift 100.00% <ø> (ø)
NAMS/EEG/EEGRecording.swift 89.62% <ø> (ø)
NAMS/EEG/ListRow.swift 100.00% <ø> (ø)
... and 20 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e84b2a5...bcc4b92. Read the comment docs.

@Supereg Supereg merged commit f992823 into main Nov 17, 2023
7 checks passed
@Supereg Supereg deleted the feature/spezi-0.8.0-upgrade branch November 17, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant