List users and patients

[arkadiuszbachorski]

List users and patients

♻️ Current situation & Problem

Users and patients need to be listed.

⚙️ Release Notes

• Add features to DataTable
• Create "Users" list page
• Create "Patients list" page

✅ Testing

Patients and users views will be covered with E2E tests later, hence drop in code coverage

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• I agree to follow the Code of Conduct and Contributing Guidelines.

[codecov]

Codecov Report

Attention: Patch coverage is 46.45477% with 219 lines in your changes missing coverage. Please review.

Project coverage is 55.87%. Comparing base (ceaa0ba) to head (ac66690).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   61.47%   55.87%   -5.60%     
==========================================
  Files          73       99      +26     
  Lines         558      938     +380     
  Branches       90      169      +79     
==========================================
+ Hits          343      524     +181     
- Misses        204      390     +186     
- Partials       11       24      +13     

Files	Coverage Δ
app/(dashboard)/User.tsx	0.00% <ø> (ø)
authServiceWorker.ts	0.00% <ø> (ø)
...ges/design-system/src/components/Button/Button.tsx	100.00% <ø> (ø)
...design-system/src/components/CopyText/CopyText.tsx	100.00% <100.00%> (ø)
...es/design-system/src/components/CopyText/index.tsx	100.00% <100.00%> (ø)
...system/src/components/DataTable/DataTable.mocks.ts	100.00% <100.00%> (ø)
...system/src/components/DataTable/DataTable.utils.ts	100.00% <100.00%> (ø)
...ign-system/src/components/DataTable/EmptyState.tsx	100.00% <100.00%> (ø)
...tem/src/components/DataTable/GlobalFilterInput.tsx	100.00% <100.00%> (ø)
...ents/DataTable/RowDropdownMenu/RowDropdownMenu.tsx	100.00% <100.00%> (ø)
... and 36 more

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceaa0ba...ac66690. Read the comment docs.

[PSchmiedmayer]

Thank you for working on these features @arkadiuszbachorski!

I had a very quick first look!
It would be great to get the new components into the storyboard to inspect more closely but everything already looks cool on the video you shared on Slack!

I have also tried to run the current setup locally but unfortunately get the following error once logging in:

Could be that this is an issue with the backend authentication, I at least used a user with admin permission according to the Firebase datastore. Let me know what setup you use at the moment to render the components and to inspect the setup.

We should setup a Firebase-Emulator enabled testing environment to make sure that we can easily test the mobile apps & web dashboard in a reproducible manner. CC @pauljohanneskraft.

[PSchmiedmayer]

TODO to ensure that we remove the admin SDK before we merge the PR; we should ensure that we don't use the admin SDK in the client-facing web dashboard.

[arkadiuszbachorski]

firebase-admin is used for retrieving user's auth data. We can't get it through Firestore. For example, to retrieve patients data, we need to combine data from user's auth and user collection.

User can access other users data only if authenticated, for their respective roles and firebase-admin is executed on the server only. I agree it probably would be better if it was separate Firebase function, but that shouldn't be blocking for now.

[PSchmiedmayer]

@pauljohanneskraft Would it make sense & doable to extract that functionality in a cloud function so we can avoid that work in the frontend codebase & ensure that we don't need to embed admin SDK keys?

On a general level: I think we should generally use the firebase queries using the client SDK when possible to ensure that we build on top of the Security Rules but in some edge cases we should selectively use cloud functions if needed.

[arkadiuszbachorski]

I had a very quick first look! It would be great to get the new components into the storyboard to inspect more closely but everything already looks cool on the video you shared on Slack!

Everything will have their Storybooks, WIP!

Could be that this is an issue with the backend authentication, I at least used a user with admin permission according to the Firebase datastore. Let me know what setup you use at the moment to render the components and to inspect the setup.

This was caused by wrong permission rules, the thing I raised on Slack. I just rollbacked to previous rules, it should work correctly now.

We should setup a Firebase-Emulator enabled testing environment to make sure that we can easily test the mobile apps & web dashboard in a reproducible manner. CC @pauljohanneskraft.

Agree, now I am just using live Firebase data.

[PSchmiedmayer]

Thank you for continuing to improve this @arkadiuszbachorski! Sounds good; let's sync up with @pauljohanneskraft so we can combine this with the firebase setup to have a nice emulator testing environment.

[arkadiuszbachorski]

@PSchmiedmayer I updated this PR with:

• tests and storybooks
• emulators support
• removed usage of firebase-admin in favor of calling getUsersInformation function
• resolved couple other todos, improvements

There is drop in coverage, because I didn't cover users and patients listing flow. It will be a separate E2E effort.

Functions types are copied from Firebase repository temporarily, it will be a shared package in the future