Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Docker Container #145

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Feature Docker Container #145

merged 6 commits into from
Sep 27, 2024

Conversation

Basler182
Copy link
Collaborator

Feature Docker

♻️ Current situation & Problem

Currently, setting up Firebase emulators requires manual installation and platform-specific scripts, which can cause issues, especially on Windows. This complicates the development process across different environments.

⚙️ Release Notes

  • Added a Docker setup for Firebase emulators with a Dockerfile and docker-compose.yml for easier cross-platform usage, especially on Windows.
  • Updated README.md with instructions on using Docker for emulators.
  • Modified serve:seeded script in functions/package.json to handle execution inside Docker containers.

image

image

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Basler182 Basler182 added the enhancement New feature or request label Sep 26, 2024
@Basler182 Basler182 self-assigned this Sep 26, 2024
@Basler182
Copy link
Collaborator Author

i had to make small changes to ‘serve:seeded’ in the package.json, since i unfortunately couldn't check it myself, it would be great if you could maybe see if it still works without docker, @pauljohanneskraft . the desired logic would be that if the ENV is not set, the previous already existing code is simply executed. thanks for checking.

Copy link
Collaborator

@pauljohanneskraft pauljohanneskraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you very much for working on this! 😊 Yes, the existing behavior of npm run serve:seeded also still works without the docker setup.

To make the REUSE compliance check work, we would need to have two files (with the content of say firebase.json.license) at Dockerfile.license and docker-compose.yml.license or it would need to be included in the header in the respective comment format (similar to the source files in this repository for example).

@Basler182 Basler182 merged commit 430235f into main Sep 27, 2024
6 checks passed
@Basler182 Basler182 deleted the feature/docker branch September 27, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants