Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to correctly allow access to user collections #144

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

pauljohanneskraft
Copy link
Collaborator

@pauljohanneskraft pauljohanneskraft commented Sep 24, 2024

Make sure to correctly allow access to user collections

♻️ Current situation & Problem

@arkadiuszbachorski noticed that clinicians and/or owners do not have the expected access to some user collections. This PR should address this and safeguard future changes to the Firestore rules with a regression test.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@pauljohanneskraft pauljohanneskraft linked an issue Sep 24, 2024 that may be closed by this pull request
1 task
@pauljohanneskraft pauljohanneskraft self-assigned this Sep 24, 2024
@pauljohanneskraft pauljohanneskraft added the bug Something isn't working label Sep 24, 2024
@pauljohanneskraft pauljohanneskraft marked this pull request as ready for review September 24, 2024 20:23
Copy link
Contributor

@arkadiuszbachorski arkadiuszbachorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it locally and works as expected. Thank you!

@pauljohanneskraft pauljohanneskraft merged commit 8bd8b0a into main Sep 25, 2024
6 checks passed
@pauljohanneskraft pauljohanneskraft deleted the user-collection-rules branch September 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reading appointments as clinician
2 participants