Improve callable and schema validator types #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pauljohanneskraft
approved these changes
Sep 10, 2024
arkadiuszbachorski
added a commit
to StanfordBDHG/ENGAGE-HF-Web-Frontend
that referenced
this pull request
Sep 15, 2024
# Use engagehf-models package ## ♻️ Current situation & Problem Previously, model types were copied from Firebase repository. This PR aims to clean this up. Closes #15 ## ✅ Testing It's a draft, because it relies on features from StanfordBDHG/ENGAGE-HF-Firebase#128 to work. We can merge this as StanfordBDHG/ENGAGE-HF-Firebase#128 gets released. ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve callable and schema validator types
♻️ Current situation & Problem
This PR aims to make types more accurate within Firebase repository and to make
@stanfordbdhg/engagehf-modelspackage more accurate and useful.I described changes more in detail in comments.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: