Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add format process on generate command #46

Closed
wants to merge 1 commit into from

Conversation

akifarhan
Copy link

@akifarhan akifarhan commented Jun 25, 2024

This PR introduces a formatting process for the stacked generate command to ensure the generated files adhere to the user-defined line length. This enhancement aligns the behaviour of the stacked generate command with the stacked create command, which already formats files according to the specified line length.

Context:
Refer to the discussion here.

Changes:

  • Added a dart format command execution at the end of the stacked generate process to ensure files are formatted according to the specified line length.
  • Ensured that the formatting command respects the line-length option set by the user during the initial project creation.

@@ -41,13 +41,16 @@ class GenerateCommand extends Command {
@override
Future<void> run() async {
try {
final workingDirectory = argResults!.rest.first;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually in this case, this won't work because there is no path supplied to the generate command.

Please turn your original request into an issue and I'll see if we can get to it next week. We'll be spending some time working through Stacked issues next week and the week after.

@FilledStacks
Copy link
Contributor

🎉 This issue has been resolved in version 1.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants