Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add-platform-and-org-name-on-create-app #18

Conversation

sebastianbuechler
Copy link
Contributor

@sebastianbuechler sebastianbuechler commented May 1, 2023

TODOs

  • adding optional arguments
  • validate optional arguments
  • update templates
  • update templates rendering

Unclear yet

  • In process_service.dart I added the optional arguments and pass them as the arguments variable which is a list of strings, but I'm not sure if this is the right approach as the information about the variable name (i.e. platforms) is lost
  • How to test the runCreateApp method

Remarks
In the readme file, there is already a placeholder for "Running the code." It would be helpful to have this guide when creating such a PR.

@sebastianbuechler sebastianbuechler marked this pull request as draft May 1, 2023 12:32
@josipbarisic
Copy link

@FilledStacks this would be a major addition to "stacked create app" command. Options to choose platforms and to specify the bundle ID are a must-have IMO. Can we maybe expect this in the next version release of stacked_cli?

@FilledStacks
Copy link
Contributor

This feature is incomplete. But we have selected this for next weeks work so it should be in by the end of next week 🤞

@ferrarafer
Copy link
Contributor

ferrarafer commented Jun 23, 2023

I added this functionality on the latest release, closing the PR.

@ferrarafer ferrarafer closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants