This repository has been archived by the owner on Aug 19, 2019. It is now read-only.
Allow supplying callbacks for specific endpoints in the API server. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorpeshansky
force-pushed
the
igorp-named-api-handlers
branch
3 times, most recently
from
77644ee to
146bdd5
Compare
bmoyles0117
suggested changes
Mar 30, 2018
| : handler_(config, store), | ||
| : config_(config), store_(store), dispatcher_({ | ||
| {{"GET", "/monitoredResource/"}, | ||
| [=](const HttpServer::request& request, |
There was a problem hiding this comment.
Is it possible to just pass HandleMonitoredResource, without doing so in a lambda? This would work in Javascript, but I know C++ is much stricter than javascript, I think anything is stricter than Javascript :-P
There was a problem hiding this comment.
No, because we also need to capture this. If there were no capture, you could indeed convert a function pointer into an std::function.
| if (config_.VerboseLogging()) { | ||
| LOG(INFO) << "Found resource for " << id << ": " << resource; | ||
| } | ||
| conn->set_status(HttpServer::connection::ok); |
There was a problem hiding this comment.
Should you rebase off of master with the latest header updates and 404 response?
igorpeshansky
force-pushed
the
igorp-named-api-handlers
branch
from
146bdd5 to
b1376e0
Compare
igorpeshansky
commented
Mar 30, 2018
| : handler_(config, store), | ||
| : config_(config), store_(store), dispatcher_({ | ||
| {{"GET", "/monitoredResource/"}, | ||
| [=](const HttpServer::request& request, |
There was a problem hiding this comment.
No, because we also need to capture this. If there were no capture, you could indeed convert a function pointer into an std::function.
| if (config_.VerboseLogging()) { | ||
| LOG(INFO) << "Found resource for " << id << ": " << resource; | ||
| } | ||
| conn->set_status(HttpServer::connection::ok); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.