Skip to content
This repository has been archived by the owner on Aug 19, 2019. It is now read-only.

Fix up gitdir pointers in submodules on broken git versions. #82

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

igorpeshansky
Copy link
Member

Recursive submodules were created with absolute paths instead of relative paths in git 2.7.0-2.8.3. When we added recursive submodule init in #78, it broke certain build use cases (e.g., leaking mount paths out of containers). This PR fixes the issue.

Copy link
Contributor

@bmoyles0117 bmoyles0117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@supriyagarg supriyagarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpeshansky igorpeshansky merged commit e5a92a1 into master Mar 19, 2018
@igorpeshansky igorpeshansky deleted the igorp-fix-git-recursive-submodules branch March 19, 2018 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants